public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Brownell <david-b@pacbell.net>
Cc: Adrian Bunk <bunk@fs.tum.de>,
	linux-net@vger.kernel.org, jgarzik@pobox.com,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] let USB_{PEGASUS,USBNET} depend on NET_ETHERNET
Date: Mon, 29 Dec 2003 12:15:56 -0800	[thread overview]
Message-ID: <20031229201556.GE7980@kroah.com> (raw)
In-Reply-To: <3FE630D7.7070007@pacbell.net>

On Sun, Dec 21, 2003 at 03:46:31PM -0800, David Brownell wrote:
> Adrian Bunk wrote:
> >I observed the following small problem in 2.6:
> >
> >- MII depends on NET_ETHERNET
> >- USB_PEGASUS and USB_USBNET select MII, but they depend only on NET
> > 
> >The patch below lets USB_PEGASUS and USB_USBNET depend on NET_ETHERNET 
> >instead of NET to fix this issue.
> 
> Actually how about this one instead?  The PEGASUS bit is the same.
> The difference is that MII (and CRC32) are only attributed to the
> driver code that needs those ... AX8817X needs both, ZAURUS just
> needs CRC32.  The core (which should eventually become a separate
> module) shouldn't depend on those modules at all.
> 
> Also both CDCETHER and AX8817X are marked as non-experimental;
> I recall Dave Hollis submitted a patch to do that for AX8817X,
> and CDCETHER now seems to have gotten enough success reports too.

Thanks, I've merged this by hand and applied it to my trees.

greg k-h

      reply	other threads:[~2003-12-29 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-21  2:22 [2.6 patch] let USB_{PEGASUS,USBNET} depend on NET_ETHERNET Adrian Bunk
2003-12-21  2:37 ` Jeff Garzik
2003-12-21 23:46 ` David Brownell
2003-12-29 20:15   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031229201556.GE7980@kroah.com \
    --to=greg@kroah.com \
    --cc=bunk@fs.tum.de \
    --cc=david-b@pacbell.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox