From: "David S. Miller" <davem@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: Problem with dev_kfree_skb_any() in 2.6.0
Date: Mon, 29 Dec 2003 20:51:57 -0800 [thread overview]
Message-ID: <20031229205157.4c631f28.davem@redhat.com> (raw)
In-Reply-To: <3FF0FA6A.8000904@pobox.com>
On Mon, 29 Dec 2003 23:09:14 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:
> Not really... pretty much _all_ TX queue packet freeing occurs inside
> an irq handler and inside the driver spinlock. Further, we don't want
> to reinvent some sort of "queue skb for freeing" code in every driver.
There is one important detail not mentioned.
If we let the TX free occur in cpu IRQ disabled context, the
BH to actually do the work will occur as some indeterminate
time in the future after the top level IRQ spinlock release
occurs.
Unlike local_bh_enable(), local_irq_enable() does not run
softirq work. Similarly when comparing IRQ handler return
(which also runs softirq work if pending).
This is the most important reason why the suggested change is wrong.
next prev parent reply other threads:[~2003-12-30 4:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-27 23:17 Problem with dev_kfree_skb_any() in 2.6.0 Benjamin Herrenschmidt
2003-12-28 1:07 ` David S. Miller
2003-12-28 5:44 ` Benjamin Herrenschmidt
2003-12-30 4:09 ` Jeff Garzik
2003-12-30 4:51 ` David S. Miller [this message]
2003-12-30 5:15 ` Jeff Garzik
2003-12-30 6:01 ` David S. Miller
2003-12-30 6:12 ` Jeff Garzik
2003-12-30 6:13 ` David S. Miller
2003-12-30 17:43 ` Jeff Garzik
2004-01-01 20:42 ` David S. Miller
2004-01-02 2:58 ` Jeff Garzik
2004-01-06 3:54 ` David S. Miller
2003-12-30 6:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031229205157.4c631f28.davem@redhat.com \
--to=davem@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox