Re: PS2 mouse changes for 2.6

Re: PS2 mouse changes for 2.6

[walt]

Dmitry Torokhov wrote:
> On Monday 29 December 2003 09:01 am, walt wrote:

>>I see no deprecation warnings when starting the kernel with
>>psmouse_noext, which I was expecting to see.

> It is emitted with KERN_WARNING severity and is not necessary seen on
> the console. Check your dmesg.

No warnings in dmesg on two different machines booted with psmouse_noext.

I am NOT complaining -- my mouse works better today than yesterday :0)

Is there anything I can do to help with this problem (?)

Re: PS2 mouse changes for 2.6

[Dmitry Torokhov]

On Monday 29 December 2003 07:51 pm, walt wrote:
> Dmitry Torokhov wrote:
> > On Monday 29 December 2003 09:01 am, walt wrote:
> >>I see no deprecation warnings when starting the kernel with
> >>psmouse_noext, which I was expecting to see.
> >
> > It is emitted with KERN_WARNING severity and is not necessary seen on
> > the console. Check your dmesg.
>
> No warnings in dmesg on two different machines booted with
> psmouse_noext.
>
> I am NOT complaining -- my mouse works better today than yesterday :0)
>
> Is there anything I can do to help with this problem (?)

OK, when I switched the parameter processing to the new technique I missed
the fact that it requires specifying prefix (module name + '.') when the
module is compiled directly into the kernel. Therefore in the lastest -bk
you have to pass "psmouse.psmouse_noext=1" to the kernel for it to be.
recognized.

Since we already have an unique prefix (psmouse) for all parameters and
changing parameter names at this time is not desirable (IMHO) I propose
the patch below to restore the old behavior.

Dmitry

===================================================================


ChangeSet@1.1517, 2003-12-29 22:53:14-05:00, dtor_core@ameritech.net
  Input: Suppress prefix generation for psmouse parameter names
         regardless of whether psmouse is built as a module or
         compiled into the kernel image


 psmouse-base.c |    9 +++++++++
 1 files changed, 9 insertions(+)


===================================================================



diff -Nru a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
--- a/drivers/input/mouse/psmouse-base.c	Mon Dec 29 23:20:41 2003
+++ b/drivers/input/mouse/psmouse-base.c	Mon Dec 29 23:20:41 2003
@@ -22,6 +22,15 @@
 #include "synaptics.h"
 #include "logips2pp.h"
 
+/*
+ * Reset module param prefix regardless of whether we build psmouse as
+ * a module or directly into kernel, otherwise for build-in case
+ * parameters will have to be specified as psmouse.psmouse_proto which
+ * is unsightly
+ */
+#undef MODULE_PARAM_PREFIX
+#define MODULE_PARAM_PREFIX /* empty */
+
 MODULE_AUTHOR("Vojtech Pavlik <vojtech@suse.cz>");
 MODULE_DESCRIPTION("PS/2 mouse driver");
 MODULE_LICENSE("GPL");

PS2 mouse changes for 2.6

[walt]

I get good results from last night's PS2 mouse patches.  My one
problem machine now works perfectly again without the psmouse_noext
parameter I've been using for several months.

Two observations:

I see no deprecation warnings when starting the kernel with
psmouse_noext, which I was expecting to see.

The mouse is announced as a 'generic wheel mouse', but it is
really a Kensington Orbit trackball.  Unfortunately I don't
have a wheel mouse to test with, so I can't comment there.

Thanks for the fixes!

Re: PS2 mouse changes for 2.6

[Dmitry Torokhov]

On Monday 29 December 2003 09:01 am, walt wrote:
> I get good results from last night's PS2 mouse patches.  My one
> problem machine now works perfectly again without the psmouse_noext
> parameter I've been using for several months.
>
> Two observations:
>
> I see no deprecation warnings when starting the kernel with
> psmouse_noext, which I was expecting to see.

It is emitted with KERN_WARNING severity and is not necessary seen on
the console. Check you dmesg.
>
> The mouse is announced as a 'generic wheel mouse', but it is
> really a Kensington Orbit trackball.  Unfortunately I don't
> have a wheel mouse to test with, so I can't comment there.
>

The kernel does not really distinguish between different hardware
manufacturers. It tries to recognize Synaptics, Logitech and Genius, but
it relies on mouse responses to various PS/2 protocol probes. Anything
that responds to IntelliMouse (imps) protocol probes but does not respond
to ImtelliMouse Explorer (exps) probes gets labelled as "Generic Wheel
Mouse".

Dmitry