From: Mike Fedyk <mfedyk@matchmail.com>
To: linux-kernel@vger.kernel.org
Subject: [RFC][PATCH][2.4] Fix negative diskstats
Date: Tue, 30 Dec 2003 00:03:36 -0800 [thread overview]
Message-ID: <20031230080336.GP1882@matchmail.com> (raw)
Hi,
I noticed that my diskstats were reporting negative numbers, and after a
hint from Andreas Dilger I found the problem.
The variables are unsigned int, but they're being reported as signed in proc.
--- drivers/block/genhd.c.orig 2003-12-29 18:35:35.000000000 -0800
+++ drivers/block/genhd.c 2003-12-29 18:40:11.000000000 -0800
@@ -201,7 +201,7 @@
disk_round_stats(hd);
seq_printf(s, "%4d %4d %10d %s "
- "%d %d %d %d %d %d %d %d %d %d %d\n",
+ "%u %u %u %u %u %u %u %u %u %u %u\n",
gp->major, n, gp->sizes[n],
disk_name(gp, n, buf),
hd->rd_ios, hd->rd_merges,
reply other threads:[~2003-12-30 8:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031230080336.GP1882@matchmail.com \
--to=mfedyk@matchmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox