From: Rusty Russell <rusty@au1.ibm.com>
To: vatsa@in.ibm.com
Cc: linux-kernel@vger.kernel.org, lhcs-devel@lists.sourceforge.net
Subject: Re: in_atomic doesn't count local_irq_disable?
Date: Tue, 30 Dec 2003 13:37:27 +1100 [thread overview]
Message-ID: <20031230133727.5222bfac.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20031229190336.A6746@in.ibm.com>
On Mon, 29 Dec 2003 19:03:36 +0530
Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:
> do_page_fault avoids calling this down_read if we are "in_atomic()"
> Isn't in_atomic supposed to count IRQs disabled case? If not
> then shouldn't do_page_fault also check for irqs_disabled()
> before calling down_read()?
in_atomic() doesn't actually return true if irqs are disabled.
hence "(in_atomic() || irqs_disabled())" in __might_sleep.
do_page_fault should have the same test...
Thanks,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
next prev parent reply other threads:[~2003-12-30 4:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-29 13:33 in_atomic doesn't count local_irq_disable? Srivatsa Vaddagiri
2003-12-29 13:35 ` Srivatsa Vaddagiri
2003-12-30 2:37 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-29 15:13 Manfred Spraul
2003-12-30 13:26 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031230133727.5222bfac.rusty@rustcorp.com.au \
--to=rusty@au1.ibm.com \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox