From: Jens Axboe <axboe@suse.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Andrew Morton <akpm@osdl.org>,
Miquel van Smoorenburg <miquels@cistron.nl>,
linux-lvm@sistina.com, linux-kernel@vger.kernel.org,
Nick Piggin <piggin@cyberone.com.au>
Subject: Re: System hangs after echo value > /sys/block/dm-0/queue/nr_requests
Date: Wed, 31 Dec 2003 11:32:58 +0100 [thread overview]
Message-ID: <20031231103258.GT3086@suse.de> (raw)
In-Reply-To: <3FF21BE1.9070603@cs.wisc.edu>
On Tue, Dec 30 2003, Mike Christie wrote:
> Andrew Morton wrote:
>
> >Where queue_requests_store() does wake_up(&rl->wait[READ]);
> >
> >It looks like nobody has called blk_init_queue() for this queue and the
> >waitqueue head is uninitialised.
> >
>
> DM, MD, rd and loop use blk_alloc_queue and blk_queue_make_request to
> initialize their queue, because they only use the make_request_fn. The
> attached patch prevents the queue from being registered if only
> blk_alloc_queue was called.
I'm fine with that patch since we don't have any attributes in there
that apply to just remappers.
--
Jens Axboe
prev parent reply other threads:[~2003-12-31 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-29 13:00 System hangs after echo value > /sys/block/dm-0/queue/nr_requests Miquel van Smoorenburg
2003-12-30 11:42 ` Andrew Morton
2003-12-31 0:44 ` Mike Christie
2003-12-31 10:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031231103258.GT3086@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lvm@sistina.com \
--cc=michaelc@cs.wisc.edu \
--cc=miquels@cistron.nl \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox