From: viro@parcelfarce.linux.theplanet.co.uk
To: Valdis.Kletnieks@vt.edu
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: hmm..
Date: Wed, 31 Dec 2003 13:44:27 +0000 [thread overview]
Message-ID: <20031231134427.GO4176@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200312250756.hBP7ubq8014587@turing-police.cc.vt.edu>
On Thu, Dec 25, 2003 at 02:56:37AM -0500, Valdis.Kletnieks@vt.edu wrote:
> work-around because IBM refused to fix it on the grounds that the VALC macro
> was to protect against a SEGV if the macro was fed an 'int' rather than a
> 'char' (why they didn't just use 'mask[__c & 255]' is beyond me), and that you
Err...
a) is...() must be able to deal with any value that fits into unsigned char
and with EOF. Behaviour on anything else is undefined, so their argument
is obviously bogus.
b) mask[__c & 255] is _not_ a solution, simply because EOF and 255 might
have different properties. Doesn't apply to kernel, but our is...()
do not bother with EOF at all. Userland ones have to.
next prev parent reply other threads:[~2003-12-31 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 20:10 hmm John Dee
2003-12-22 21:31 ` hmm Linus Torvalds
2003-12-22 23:10 ` hmm bert hubert
2003-12-23 1:16 ` hmm Felipe Alfaro Solana
2003-12-25 7:56 ` hmm Valdis.Kletnieks
2003-12-31 6:28 ` hmm Linus Torvalds
2003-12-31 13:44 ` viro [this message]
2003-12-22 23:12 ` hmm Gene Heskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031231134427.GO4176@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox