From: Greg KH <greg@kroah.com>
To: Manuel Estrada Sainz <ranty@debian.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Dmitry Torokhov <dtor_core@ameritech.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@osdl.org>
Subject: Re: [2.6 PATCH/RFC] Firmware loader - fix races and resource dealloocation problems
Date: Wed, 31 Dec 2003 15:03:54 -0800 [thread overview]
Message-ID: <20031231230354.GA10245@kroah.com> (raw)
In-Reply-To: <20031231223244.GO24577@ranty.pantax.net>
On Wed, Dec 31, 2003 at 11:32:44PM +0100, Manuel Estrada Sainz wrote:
>
> Maybe some generic mechanism could be implemented to make the hotplug
> event wait for the files.
No.
> The least intrusive solution, although it doesn't sound quite clean could be:
>
> - Kernel side:
> - sysfs_hotplug_frezze()
> - Creates a dummy file /sys/.hotplug_frozen
> - sysfs_hotplug_thaw()
> - Removes /sys/.hotplug_frozen
> - Userspace:
> - Main hotplug script waits "while [ -f /sys/.hotplug_frozen ]".
Ick. You realize how many hotplug events we spit out already today?
This would be a huge bottleneck.
It's not that tough to just see if the file you are looking is there,
and if not sleep. If after an ammount of time the file still isn't
there, just give up.
Also, not all hotplug scripts care about sysfs files being present :)
thanks,
greg k-h
next prev parent reply other threads:[~2004-01-01 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-21 6:37 [2.6 PATCH/RFC] Firmware loader - fix races and resource dealloocation problems Dmitry Torokhov
2003-12-22 9:37 ` Greg KH
2003-12-22 23:42 ` Marcel Holtmann
2003-12-23 3:29 ` Dmitry Torokhov
2003-12-23 8:48 ` Marcel Holtmann
2003-12-27 5:29 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 Dmitry Torokhov
2003-12-27 5:29 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 (patch 1/2) Dmitry Torokhov
2003-12-27 5:30 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 (patch 2/2) Dmitry Torokhov
2003-12-31 21:31 ` Greg KH
2003-12-31 22:16 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 (patch 1/2) Manuel Estrada Sainz
2003-12-31 22:32 ` [2.6 PATCH/RFC] Firmware loader - fix races and resource dealloocation problems Manuel Estrada Sainz
2003-12-31 23:03 ` Greg KH [this message]
2003-12-22 23:05 ` Manuel Estrada Sainz
2003-12-22 23:22 ` Greg KH
2003-12-26 17:29 ` Manuel Estrada Sainz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031231230354.GA10245@kroah.com \
--to=greg@kroah.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mochel@osdl.org \
--cc=ranty@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox