public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Baruch Siach <baruch@tkos.co.il>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
Date: Thu, 08 Jan 2015 23:41:52 +0100	[thread overview]
Message-ID: <20032538.pHVo39OjvN@wuerfel> (raw)
In-Reply-To: <9d8d7aed6220e9e92ab70217a65d3291924cfa71.1420744369.git.baruch@tkos.co.il>

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd

  reply	other threads:[~2015-01-08 22:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 19:39 [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support Baruch Siach
2015-01-08 19:39 ` [PATCH v2 1/8] ARM: initial support for Conexant Digicolor CX92755 SoC Baruch Siach
2015-01-08 19:39 ` [PATCH v2 2/8] ARM: digicolor: add low level debug support Baruch Siach
2015-01-08 19:39 ` [PATCH v2 3/8] ARM: digicolor: add minimal device tree description Baruch Siach
2015-01-08 22:41   ` Arnd Bergmann [this message]
2015-01-09 11:46   ` Mark Rutland
2015-01-11  9:38     ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding Baruch Siach
2015-01-09 11:50   ` Mark Rutland
2015-01-11 11:21     ` Baruch Siach
2015-01-09 15:12   ` Sergei Shtylyov
2015-01-11 11:29     ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 5/8] irqchip: Conexant CX92755 interrupts controller driver Baruch Siach
2015-01-08 19:40 ` [PATCH v2 6/8] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-08 19:40 ` [PATCH v2 7/8] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-08 19:40 ` [PATCH v2 8/8] ARM: devicetree: document supported Conexant Digicolor SoC Baruch Siach
2015-01-08 22:46 ` [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support Arnd Bergmann
2015-01-11 11:33   ` Baruch Siach
2015-01-11 15:49     ` Arnd Bergmann
2015-01-28 22:33   ` Paul Bolle
2015-01-28 22:41     ` Baruch Siach
2015-01-28 22:52       ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20032538.pHVo39OjvN@wuerfel \
    --to=arnd@arndb.de \
    --cc=baruch@tkos.co.il \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox