From: Omkhar Arasaratnam <omkhar@rogers.com>
To: emoenke@gwdg.de
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au,
randy@kerneljanitors.org
Subject: [PATCH] drivers/cdrom/cdu31c.c check_region() fix
Date: Fri, 2 Jan 2004 11:13:06 -0500 [thread overview]
Message-ID: <20040102161306.GA7122@omkhar.ibm.com> (raw)
Here is a check_region fix for cdu31a
As usual feel free to poke / prod / suggest / include this patch as you see fit
--- linux-clean/drivers/cdrom/cdu31a.c.org 2004-01-02 10:54:01.000000000 -0500
+++ linux-clean/drivers/cdrom/cdu31a.c 2004-01-02 11:03:56.000000000 -0500
@@ -3345,7 +3345,7 @@
i = 0;
while ((cdu31a_addresses[i].base != 0)
&& (!drive_found)) {
- if (check_region(cdu31a_addresses[i].base, 4)) {
+ if (!request_region(cdu31a_addresses[i].base, 4,"cdu31a")) {
i++;
continue;
}
@@ -3359,6 +3359,7 @@
cdu31a_irq = cdu31a_addresses[i].int_num;
} else {
i++;
+ release_region(cdu31a_address[i].base,4);
}
}
}
@@ -3366,9 +3367,6 @@
if (!drive_found)
goto errout3;
- if (!request_region(cdu31a_port, 4, "cdu31a"))
- goto errout3;
-
if (register_blkdev(MAJOR_NR, "cdu31a"))
goto errout2;
O
next reply other threads:[~2004-01-02 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-02 16:13 Omkhar Arasaratnam [this message]
2004-01-02 19:02 ` [PATCH] drivers/cdrom/cdu31c.c check_region() fix viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040102161306.GA7122@omkhar.ibm.com \
--to=omkhar@rogers.com \
--cc=emoenke@gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=randy@kerneljanitors.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox