Re: [PATCH 1/2] kthread_create

Davide Libenzi
2004-01-03T03:43:46Z

On Sat, 3 Jan 2004, Rusty Russell wrote:

> In message <Pine.LNX.4.44.0401020856150.2278-100000@bigblue.dev.mdolabs.com> you write:
> > Rusty, you still have to use global static data when there is no need.
>
> And you're still putting obscure crap in the task struct when there's
> no need. Honestly, I'd be ashamed to post such a patch.

Ashamed !? Take a look at your original patch and then define shame. You
had a communication mechanism that whilst being a private 1<->1
communication among two tasks, relied on a single global message
strucure, lock and mutex. Honestly I do not like myself to add stuff
inside a strcture for one-time use. Not because of adding 12 bytes to the
struct, that are laughable. But because it is used by a small piece of
code w/out a re-use ability for other things.

> > I like this version better though ;)
>
> I think I should seek a second opinion though.

But of course, even a third one ;)

- Davide