public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: dtor_core@ameritech.net, vojtech@suse.cz, torvalds@osdl.org,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test6: APM unable to suspend (the 2.6.0-test2 saga continues)
Date: Sat, 3 Jan 2004 14:43:37 +1100	[thread overview]
Message-ID: <20040103144337.4a121f00.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20031231124032.GA367@ucw.cz>

On Wed, 31 Dec 2003 13:40:33 +0100
Vojtech Pavlik <vojtech@suse.cz> wrote:
> > +#undef MODULE_PARAM_PREFIX
> > +#define MODULE_PARAM_PREFIX /* empty */
> > +
> >  static unsigned int i8042_noaux;
> >  module_param(i8042_noaux, bool, 0);
> 
> Well, I think it might be cleaner to just drop the i8042_ prefix and go
> with the "i8042." prefix if that's the 2.6 way. It'll annoy a couple
> people, but's it's the way to go in the future.

Yeah, unless there's a good reason, it's nicer if there's symmetry so
people can guess how to pass params.

Thanks,
Rusty.
-- 
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy

  reply	other threads:[~2004-01-03 11:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-05 16:10 2.6.0-test6: APM unable to suspend (the 2.6.0-test2 saga continues) Russell King
2003-12-28 17:46 ` Russell King
2003-12-28 18:25   ` Russell King
2003-12-28 20:49     ` Linus Torvalds
2003-12-30 11:43       ` Russell King
2003-12-30 16:50         ` Russell King
2003-12-30 18:17           ` Russell King
2003-12-30 18:47             ` Linus Torvalds
2003-12-30 19:40               ` Russell King
2003-12-30 19:53                 ` Russell King
2003-12-30 23:00                   ` Vojtech Pavlik
2003-12-31  1:45                     ` Dmitry Torokhov
2003-12-31 12:40                       ` Vojtech Pavlik
2004-01-03  3:43                         ` Rusty Russell [this message]
2004-01-03 18:28             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040103144337.4a121f00.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox