public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* module_param( byte ... ) missing?
@ 2004-01-03 16:40 Juergen Quade
  2004-01-04  2:06 ` Rusty Russell
  0 siblings, 1 reply; 2+ messages in thread
From: Juergen Quade @ 2004-01-03 16:40 UTC (permalink / raw)
  To: Rusty Russell; +Cc: linux-kernel

Rusty,

using the "byte"-datatype as module parameter throws a compile error.
Other than stated in the comment of the headerfile <linux/moduleparam.h>

	/* Helper functions: type is byte, short, ushort, int, uint, long,
	   ulong, charp, bool or invbool, or XXX if you define param_get_XXX,
	   param_set_XXX and param_check_XXX. */
	#define module_param_named(name, value, type, perm)
	...
	
the datatype _byte_ seems not be implemented.
Have you dropped it intentionally?

      Juergen.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: module_param( byte ... ) missing?
  2004-01-03 16:40 module_param( byte ... ) missing? Juergen Quade
@ 2004-01-04  2:06 ` Rusty Russell
  0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2004-01-04  2:06 UTC (permalink / raw)
  To: Juergen Quade; +Cc: linux-kernel

In message <20040103164026.GA29962@hsnr.de> you write:
> Rusty,
> 
> using the "byte"-datatype as module parameter throws a compile error.
> Other than stated in the comment of the headerfile <linux/moduleparam.h>
> 
> 	/* Helper functions: type is byte, short, ushort, int, uint, long,
> 	   ulong, charp, bool or invbool, or XXX if you define param_get_XXX,
> 	   param_set_XXX and param_check_XXX. */
> 	#define module_param_named(name, value, type, perm)
> 	...
> 	
> the datatype _byte_ seems not be implemented.
> Have you dropped it intentionally?

No, just not implemented; the comment is overzealous.  

Of course, you can implement byte in two ways: you can do it in your
own module (effectively a private type), or in kernel/params.c.  I'd
prefer the former, and if lots of modules use it, we move it to
kernel/params.c.

Hope that clarifies,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-01-04  4:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-03 16:40 module_param( byte ... ) missing? Juergen Quade
2004-01-04  2:06 ` Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox