From: Muli Ben-Yehuda <mulix@mulix.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel@vger.kernel.org, H.T.M.v.d.Maarel@marin.nl
Subject: Re: [patch against 2.6.1-rc1-mm1] replace check_region with request_region in isp16.c
Date: Sat, 3 Jan 2004 19:26:41 +0200 [thread overview]
Message-ID: <20040103172639.GQ1718@actcom.co.il> (raw)
In-Reply-To: <Pine.LNX.4.56.0401031750330.4664@jju_lnx.backbone.dif.dk>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
On Sat, Jan 03, 2004 at 06:06:20PM +0100, Jesper Juhl wrote:
> One thing that surprised me was that the isp16 driver does not seem to
> ever call request_region, it only ever calls check_region which confuses
> me a bit - wouldn't it need to (also with older kernels) always call
> request_region ?
I think so. It looks broken as it was, playing with the IO region
without requesting it first. Is anyone actually using this driver?
> I would appreciate it is someone could take a quick look at the patch and
> verify that it does the correct thing.
Looks correct to me.
Chers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/
"the nucleus of linux oscillates my world" - gccbot@#offtopic
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-01-03 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-03 17:06 [patch against 2.6.1-rc1-mm1] replace check_region with request_region in isp16.c Jesper Juhl
2004-01-03 17:26 ` Muli Ben-Yehuda [this message]
2004-01-03 19:12 ` [patch against 2.6.1-rc1-mm1] replace check_region with reque st_region " Jesper Juhl
2004-01-03 17:32 ` [patch against 2.6.1-rc1-mm1] replace check_region with request_region " Petri Koistinen
2004-01-03 17:40 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040103172639.GQ1718@actcom.co.il \
--to=mulix@mulix.org \
--cc=H.T.M.v.d.Maarel@marin.nl \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox