From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [minor & trivial patch] kill some potential warnings about inline keyword placement - 2.6.1-rc1-mm1
Date: Sun, 4 Jan 2004 00:09:55 +0000 [thread overview]
Message-ID: <20040104000955.B11953@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.56.0401040046450.4664@jju_lnx.backbone.dif.dk>; from juhl-lkml@dif.dk on Sun, Jan 04, 2004 at 01:01:26AM +0100
On Sun, Jan 04, 2004 at 01:01:26AM +0100, Jesper Juhl wrote:
> --- linux-2.6.1-rc1-mm1-orig/include/linux/efi.h 2003-12-31 05:48:26.000000000 +0100
> +++ linux-2.6.1-rc1-mm1/include/linux/efi.h 2004-01-04 00:29:48.000000000 +0100
> @@ -297,8 +297,8 @@ extern u64 efi_mem_attributes (unsigned
> extern void efi_initialize_iomem_resources(struct resource *code_resource,
> struct resource *data_resource);
> extern efi_status_t phys_efi_get_time(efi_time_t *tm, efi_time_cap_t *tc);
> -extern unsigned long inline __init efi_get_time(void);
> -extern int inline __init efi_set_rtc_mmss(unsigned long nowtime);
> +inline extern unsigned long __init efi_get_time(void);
> +inline extern int __init efi_set_rtc_mmss(unsigned long nowtime);
For the sake of consistency, can we keep these the same as the rest
of the kernel code please? IOW:
extern inline unsigned long __init efi_get_time(void);
Thanks.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-01-04 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-04 0:01 [minor & trivial patch] kill some potential warnings about inline keyword placement - 2.6.1-rc1-mm1 Jesper Juhl
2004-01-04 0:09 ` Russell King [this message]
2004-01-04 0:18 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104000955.B11953@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox