From: Dave Jones <davej@redhat.com>
To: Srihari Vijayaraghavan <harisri@bigpond.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: agpgart issue on 2.6.1-rc1-bk3 (x86-64)
Date: Sun, 4 Jan 2004 02:12:46 +0000 [thread overview]
Message-ID: <20040104021246.GB10650@redhat.com> (raw)
In-Reply-To: <200401041228.22987.harisri@bigpond.com>
On Sun, Jan 04, 2004 at 12:28:22PM +1100, Srihari Vijayaraghavan wrote:
> Hello,
>
> I see this message in the 2.6.1-rc3-bk3 kernel log:
> agpgart: Detected AGP bridge 0
> agpgart: Too many northbridges for AGP
>
> This results in <100 FPS in glxgears, and I am unable to play the tuxracer
> game :-). With 2.6.0-x8664-1 however I get 450 FPS (approx), and all was
> well.
>
> Upon applying this patch (making it identical to 2.6.0-x86-64 that is):
> --- 2.6.1-rc1-bk3/drivers/char/agp/amd64-agp.c.orig 2004-01-04
> 01:06:20.000000000 +1100
> +++ 2.6.1-rc1-bk3/drivers/char/agp/amd64-agp.c 2004-01-04 01:06:50.000000000
> +1100
> @@ -16,11 +16,7 @@
> #include "agp.h"
>
> /* Will need to be increased if AMD64 ever goes >8-way. */
> -#ifdef CONFIG_SMP
> #define MAX_HAMMER_GARTS 8
> -#else
> -#define MAX_HAMMER_GARTS 1
> -#endif
Wrong fix. Amongst another bunch of AGP fixes going to Linus/Andrew
on Monday is the following..
(Andi also sent me another amd64 update, which I'll merge before
pushing Linuswards)
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/char/agp/amd64-agp.c linux-2.5/drivers/char/agp/amd64-agp.c
--- bk-linus/drivers/char/agp/amd64-agp.c 2003-10-17 20:53:49.000000000 +0100
+++ linux-2.5/drivers/char/agp/amd64-agp.c 2003-12-02 02:05:32.000000000 +0000
@@ -357,11 +356,18 @@ static __devinit int cache_nbs (struct p
}
hammers[i++] = loop_dev;
nr_garts = i;
- if (i == MAX_HAMMER_GARTS) {
+#ifdef CONFIG_SMP
+ if (i > MAX_HAMMER_GARTS) {
printk(KERN_INFO PFX "Too many northbridges for AGP\n");
return -1;
}
+#else
+ /* Uniprocessor case, return after finding first bridge.
+ (There may be more, but in UP, we don't care). */
+ return 0;
+#endif
}
+
return i == 0 ? -1 : 0;
}
--
Dave Jones http://www.codemonkey.org.uk
next prev parent reply other threads:[~2004-01-04 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-04 1:28 agpgart issue on 2.6.1-rc1-bk3 (x86-64) Srihari Vijayaraghavan
2004-01-04 2:12 ` Dave Jones [this message]
2004-01-07 11:21 ` Srihari Vijayaraghavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104021246.GB10650@redhat.com \
--to=davej@redhat.com \
--cc=harisri@bigpond.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox