* [PATCH] Remove Intel check in i386 HPET code
@ 2004-01-04 13:13 Andi Kleen
2004-01-04 21:56 ` Vojtech Pavlik
2004-03-29 15:43 ` Vojtech Pavlik
0 siblings, 2 replies; 4+ messages in thread
From: Andi Kleen @ 2004-01-04 13:13 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, akpm
The i386 HPET time setup code would explicitely check for the Intel
vendor ID. That is bogus because other chipset vendors (like AMD)
are implementing HPET too.
Remove this check.
-Andi
diff -u linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c
--- linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ 2004-01-04 14:10:59.000000000 +0100
+++ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c 2004-01-04 14:10:59.000000000 +0100
@@ -91,10 +91,6 @@
!(id & HPET_ID_LEGSUP))
return -1;
- if (((id & HPET_ID_VENDOR) >> HPET_ID_VENDOR_SHIFT) !=
- HPET_ID_VENDOR_8086)
- return -1;
-
hpet_period = hpet_readl(HPET_PERIOD);
if ((hpet_period < HPET_MIN_PERIOD) || (hpet_period > HPET_MAX_PERIOD))
return -1;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove Intel check in i386 HPET code
2004-01-04 13:13 [PATCH] Remove Intel check in i386 HPET code Andi Kleen
@ 2004-01-04 21:56 ` Vojtech Pavlik
2004-03-29 15:43 ` Vojtech Pavlik
1 sibling, 0 replies; 4+ messages in thread
From: Vojtech Pavlik @ 2004-01-04 21:56 UTC (permalink / raw)
To: Andi Kleen; +Cc: torvalds, linux-kernel, akpm
On Sun, Jan 04, 2004 at 02:13:50PM +0100, Andi Kleen wrote:
>
> The i386 HPET time setup code would explicitely check for the Intel
> vendor ID. That is bogus because other chipset vendors (like AMD)
> are implementing HPET too.
>
> Remove this check.
You can also remove the HPET_ID_VENDOR_8086 definition.
>
> -Andi
>
> diff -u linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c
> --- linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ 2004-01-04 14:10:59.000000000 +0100
> +++ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c 2004-01-04 14:10:59.000000000 +0100
> @@ -91,10 +91,6 @@
> !(id & HPET_ID_LEGSUP))
> return -1;
>
> - if (((id & HPET_ID_VENDOR) >> HPET_ID_VENDOR_SHIFT) !=
> - HPET_ID_VENDOR_8086)
> - return -1;
> -
> hpet_period = hpet_readl(HPET_PERIOD);
> if ((hpet_period < HPET_MIN_PERIOD) || (hpet_period > HPET_MAX_PERIOD))
> return -1;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Vojtech Pavlik
SuSE Labs, SuSE CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove Intel check in i386 HPET code
2004-01-04 13:13 [PATCH] Remove Intel check in i386 HPET code Andi Kleen
2004-01-04 21:56 ` Vojtech Pavlik
@ 2004-03-29 15:43 ` Vojtech Pavlik
1 sibling, 0 replies; 4+ messages in thread
From: Vojtech Pavlik @ 2004-03-29 15:43 UTC (permalink / raw)
To: Administrator; +Cc: torvalds, linux-kernel, akpm
On Sun, Jan 04, 2004 at 02:13:50PM +0100, Andi Kleen wrote:
>
> The i386 HPET time setup code would explicitely check for the Intel
> vendor ID. That is bogus because other chipset vendors (like AMD)
> are implementing HPET too.
>
> Remove this check.
You can also remove the HPET_ID_VENDOR_8086 definition.
>
> -Andi
>
> diff -u linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c
> --- linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ 2004-01-04 14:10:59.000000000 +0100
> +++ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c 2004-01-04 14:10:59.000000000 +0100
> @@ -91,10 +91,6 @@
> !(id & HPET_ID_LEGSUP))
> return -1;
>
> - if (((id & HPET_ID_VENDOR) >> HPET_ID_VENDOR_SHIFT) !=
> - HPET_ID_VENDOR_8086)
> - return -1;
> -
> hpet_period = hpet_readl(HPET_PERIOD);
> if ((hpet_period < HPET_MIN_PERIOD) || (hpet_period > HPET_MAX_PERIOD))
> return -1;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Vojtech Pavlik
SuSE Labs, SuSE CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Remove Intel check in i386 HPET code
@ 2004-03-29 15:42 Andi Kleen
0 siblings, 0 replies; 4+ messages in thread
From: Andi Kleen @ 2004-03-29 15:42 UTC (permalink / raw)
To: Administrator; +Cc: linux-kernel, akpm
The i386 HPET time setup code would explicitely check for the Intel
vendor ID. That is bogus because other chipset vendors (like AMD)
are implementing HPET too.
Remove this check.
-Andi
diff -u linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c
--- linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ 2004-01-04 14:10:59.000000000 +0100
+++ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c 2004-01-04 14:10:59.000000000 +0100
@@ -91,10 +91,6 @@
!(id & HPET_ID_LEGSUP))
return -1;
- if (((id & HPET_ID_VENDOR) >> HPET_ID_VENDOR_SHIFT) !=
- HPET_ID_VENDOR_8086)
- return -1;
-
hpet_period = hpet_readl(HPET_PERIOD);
if ((hpet_period < HPET_MIN_PERIOD) || (hpet_period > HPET_MAX_PERIOD))
return -1;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-03-29 15:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-04 13:13 [PATCH] Remove Intel check in i386 HPET code Andi Kleen
2004-01-04 21:56 ` Vojtech Pavlik
2004-03-29 15:43 ` Vojtech Pavlik
-- strict thread matches above, loose matches on Subject: below --
2004-03-29 15:42 Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox