public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Javier Marcet <lists@marcet.info>
To: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
Cc: linux-kernel@vger.kernel.org, usb-storage@one-eyed-alien.net,
	linux-usb-users@lists.sourceforge.net
Subject: Re: usb-storage && iRIVER flash player problem
Date: Mon, 5 Jan 2004 21:03:33 +0100	[thread overview]
Message-ID: <20040105200333.GA11318@hiroshi> (raw)
In-Reply-To: <20040105190204.GA4547@one-eyed-alien.net>

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

* Matthew Dharm <mdharm-kernel@one-eyed-alien.net> [040105 20:02]:

>It looks like your device is choking over the ALLOW_MEDIUM_REMOVAL command
>-- I've never seen a device broken in this particular way before.

>If you edit drivers/scsi/sd.c to remove the sending of that command (it's
>normally used to lock the media-eject button on devices that support it),
>we should be able to test this theory.  If this is the case, then we may
>need to modify the SCSI layer to only send that command if the RMB bit is
>set.

That did it, with this fix I have no problems. fdisk still reports
mangled partitions, parted OTOH reports one partition filling the whole
device. I can mount either /dev/sda or /dev/sda4 and get the same
correct results.

Thanks a lot :) You've made me happy for the coming days ;)
Until your message I was messing around with unusual_devs.h to no
avail...


-- 
Javier Marcet <javier@marcet.info>

[-- Attachment #2: usb-storage_ifpdev_fix.patch --]
[-- Type: text/plain, Size: 347 bytes --]

--- linux/drivers/scsi/scsi_ioctl.c.orig	2004-01-01 09:12:20.000000000 +0100
+++ linux/drivers/scsi/scsi_ioctl.c	2004-01-05 20:42:03.979349544 +0100
@@ -156,7 +156,7 @@
 	if (!sdev->removable || !sdev->lockable)
 	       return 0;
 
-	scsi_cmd[0] = ALLOW_MEDIUM_REMOVAL;
+	scsi_cmd[0] = 0;
 	scsi_cmd[1] = 0;
 	scsi_cmd[2] = 0;
 	scsi_cmd[3] = 0;

  reply	other threads:[~2004-01-05 20:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-05 12:59 usb-storage && iRIVER flash player problem Javier Marcet
2004-01-05 19:02 ` Matthew Dharm
2004-01-05 20:03   ` Javier Marcet [this message]
2004-01-06  6:56     ` [usb-storage] " Matthew Dharm
2004-01-06 15:37       ` Alan Stern
2004-01-06 20:32         ` Javier Marcet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040105200333.GA11318@hiroshi \
    --to=lists@marcet.info \
    --cc=javier@marcet.info \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-users@lists.sourceforge.net \
    --cc=mdharm-kernel@one-eyed-alien.net \
    --cc=usb-storage@one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox