Re: [PATCH] Simplify node/zone field in page->flags

Martin Schlemmer
2004-01-07T16:40:57Z

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

On Wed, 2004-01-07 at 00:25, Matthew Dobson wrote:

> >
> > Get this with gcc-3.3.2 cvs:
> >
> > --
> > include/linux/mm.h: In function `page_nodenum':
> > include/linux/mm.h:337: warning: right shift count >= width of type
> > include/linux/mm.h:337: warning: suggest parentheses around + or -
> > inside shift
> > --
> >
> > Think we could get those () in to make it more clear and the compiler
> > happy?
> >
> >
> > Thanks,
> >
>
> Figured out what the right shift count message was about. On UP with
> MAX_NODES_SHIFT = 0, the node bitfield has no length so the bitshift was
> too far. Setting MAX_NODES_SHIFT = 1 gives the node bitfield a size of
> 1, and we just store a 0 there for node 0.
>
> Updated patch attatched.

Hmm, have smp here:

--
# grep SMP /usr/src/linux-2.6.1-rc1-bk6/.config
CONFIG_BROKEN_ON_SMP=y
# CONFIG_X86_BIGSMP is not set
CONFIG_SMP=y
CONFIG_X86_FIND_SMP_CONFIG=y
CONFIG_X86_SMP=y
--

but yes, last patch fixes it!

Thanks,

--
Martin Schlemmer

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]