From: Rusty Russell <rusty@rustcorp.com.au>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: Ville Herva <vherva@twilight.cs.hut.fi>
Cc: xavier.bestel@free.fr, linux-kernel@vger.kernel.org
Subject: Re: floppy driver and multiple floppies (was Re: 2.6.0 under vmware ?)
Date: Wed, 07 Jan 2004 14:21:29 +1100 [thread overview]
Message-ID: <20040107034042.5942D2C066@lists.samba.org> (raw)
In-Reply-To: Your message of "Mon, 05 Jan 2004 18:14:31 BST." <20040105171431.GA1776@vana.vc.cvut.cz>
In message <20040105171431.GA1776@vana.vc.cvut.cz> you write:
> -MODULE_PARM(floppy,"s");
> -MODULE_PARM(FLOPPY_IRQ,"i");
> -MODULE_PARM(FLOPPY_DMA,"i");
> +module_param(floppy, charp, 0);
> +module_param(FLOPPY_IRQ, int, 0);
> +module_param(FLOPPY_DMA, int, 0);
You really don't want these to be visible through sysfs? I'd expect
0444 rather than 0 as the last arg...
Also it'd be nice to do furthur cleanups and get rid of the #ifdef
MODULE altogether...
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2004-01-07 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 10:06 2.6.0 under vmware ? Xavier Bestel
2004-01-05 11:21 ` Ernst Herzberg
2004-01-05 11:35 ` Alexander Hoogerhuis
2004-01-06 5:44 ` Zwane Mwaikambo
2004-01-05 14:20 ` Ville Herva
2004-01-05 17:14 ` floppy driver and multiple floppies (was Re: 2.6.0 under vmware ?) Petr Vandrovec
2004-01-07 3:21 ` Rusty Russell [this message]
2004-01-05 18:55 ` 2.6.0 under vmware ? Ville Herva
2004-01-05 19:30 ` Stephen Hemminger
2004-01-05 19:50 ` Ville Herva
[not found] ` <20040105111549.GD11115091@niksula.cs.hut.fi>
2004-01-05 15:20 ` Xavier Bestel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040107034042.5942D2C066@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=vandrove@vc.cvut.cz \
--cc=vherva@twilight.cs.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox