public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Pavel Machek <pavel@suse.cz>
Cc: Andrew Morton <akpm@zip.com.au>,
	kernel list <linux-kernel@vger.kernel.org>,
	vojtech@suse.cz
Subject: Re: Alt-arrow console switch sometimes dropped
Date: Thu, 08 Jan 2004 10:55:59 +1100	[thread overview]
Message-ID: <20040108002255.0EC092C44B@lists.samba.org> (raw)
In-Reply-To: Your message of "Sat, 03 Jan 2004 14:37:46 BST." <20040103133746.GA516@elf.ucw.cz>

In message <20040103133746.GA516@elf.ucw.cz> you write:
> Hi!
> 
> Alt-arrow console switch is routinely dropped under high load. This
> patch fixes it: alt-arrow has to start from console _we want to switch
> to_, if switch is already pending. Please apply,
> 								Pavel

Sure, but a comment would be nice:

	/* Currently switching?  Queue this next switch relative to that. */

Thanks,
Trivial Rusty.

> Index: linux.new/drivers/char/keyboard.c
> ===================================================================
> --- linux.new.orig/drivers/char/keyboard.c	2003-12-25 13:28:51.000000000 +0100
> +++ linux.new/drivers/char/keyboard.c	2003-12-25 13:29:08.000000000 +0100
> @@ -507,8 +528,12 @@
>  static void fn_inc_console(struct vc_data *vc, struct pt_regs *regs)
>  {
>  	int i;
> +	int cur = fg_console;
>  
> -	for (i = fg_console+1; i != fg_console; i++) {
> +	if (want_console != -1)
> +		cur = want_console;
> +
> +	for (i = cur+1; i != cur; i++) {
>  		if (i == MAX_NR_CONSOLES)
>  			i = 0;
>  		if (vc_cons_allocated(i))
> 
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  reply	other threads:[~2004-01-08  0:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-03 13:37 Alt-arrow console switch sometimes dropped Pavel Machek
2004-01-07 23:55 ` Rusty Russell [this message]
2004-01-09 18:10   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040108002255.0EC092C44B@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox