Re: kgdb cleanups

[Matt Mackall <mpm@selenic.com>]

On Sat, Jan 10, 2004 at 08:34:06PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > >>>Hi!
> > > >>>
> > > >>>No real code changes, but cleanups all over the place. What about
> > > >>>applying?
> > > >>>
> > > >>>Ouch and arch-dependend code is moved to kernel/kgdb.c. I'll probably
> > > >>>do x86-64 version so that is rather important.
> > > >>>
> > > >>>								Pavel
> > > >>
> > > >>A few comments:
> > > >>
> > > >>I like the code seperation.  Does it follow what Amit is doing?  It would 
> > > >>be nice if Amit's version and this one could come together around this.
> > > >>
> > > >>I don't think we want to merge the eth and regular kgdb just yet.  I 
> > > >>would, however, like to keep eth completly out of the stub.  Possibly a 
> > > >>new module which just takes care of steering the I/O to the correct place.
> > > >
> > > >
> > > >I've sent Amit the start of an plug interface for abstracting the
> > > >communication layer. Should be relatively painless and allow for
> > > >starting sessions on the interface of your choice.
> > > >
> > > May I see?
> > 
> > Here's the interface plus the eth side of it:
> 
> Does it work with those patches? (Amid's version does not seem to work
> over ethernet).

The stuff currently in -mm and -tiny works. The "pluggable" bits are
proof of concept at this stage and I've been busy working on other
things - was hoping someone else would run with them.

-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting