public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Andreas Haumer <andreas@xss.co.at>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org, jgarzik@pobox.com,
	linux-net@vger.kernel.org
Subject: [2.4 patch] simplify COMX_PROTO_LAPB dependencies
Date: Tue, 13 Jan 2004 01:58:57 +0100	[thread overview]
Message-ID: <20040113005857.GY9677@fs.tum.de> (raw)
In-Reply-To: <3FF2EAB3.1090001@xss.co.at>

On Wed, Dec 31, 2003 at 04:26:43PM +0100, Andreas Haumer wrote:
> 
> Hi!

Hi Andreas!

>...
> Here's a first report:
>...
>    - Double (but deactivated) entry in config dialog for
>...
>      + "Wan Interfaces" / "Support for LAPB protocol on MultiGate boards"
>...

Thanks for this report.

The patch below fixes this issue, and as a side effect it's also a great
simplification (while remaining semantically equivalent with the
original dependencies).

cu
Adrian

--- linux-2.4.25-pre4-full/drivers/net/wan/Config.in.old	2004-01-13 01:48:47.000000000 +0100
+++ linux-2.4.25-pre4-full/drivers/net/wan/Config.in	2004-01-13 01:49:51.000000000 +0100
@@ -30,12 +30,7 @@
       dep_tristate '    Support for MixCOM board' CONFIG_COMX_HW_MIXCOM $CONFIG_COMX
       dep_tristate '    Support for MUNICH based boards: SliceCOM, PCICOM (WelCOM)' CONFIG_COMX_HW_MUNICH $CONFIG_COMX
       dep_tristate '    Support for HDLC and syncPPP protocols on MultiGate boards' CONFIG_COMX_PROTO_PPP $CONFIG_COMX
-      if [ "$CONFIG_LAPB" = "y" ]; then
-	 dep_tristate '    Support for LAPB protocol on MultiGate boards' CONFIG_COMX_PROTO_LAPB $CONFIG_COMX
-      fi
-      if [ "$CONFIG_LAPB" = "m" ]; then
-	 dep_tristate '    Support for LAPB protocol on MultiGate boards' CONFIG_COMX_PROTO_LAPB $CONFIG_LAPB
-      fi
+      dep_tristate '    Support for LAPB protocol on MultiGate boards' CONFIG_COMX_PROTO_LAPB $CONFIG_LAPB $CONFIG_COMX
       dep_tristate '    Support for Frame Relay on MultiGate boards' CONFIG_COMX_PROTO_FR $CONFIG_COMX
    fi
 

  parent reply	other threads:[~2004-01-13  0:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-31 13:13 Linux 2.4.24-pre3 Marcelo Tosatti
2003-12-31 13:53 ` Tim Cambrant
2003-12-31 15:26 ` Andreas Haumer
2004-01-10  1:39   ` [2.4 patch] fix CONFIG_DS1742 Config.in entry Adrian Bunk
2004-01-11  1:30   ` [2.4 patch] disallow modular CONFIG_COMX Adrian Bunk
2004-01-12 22:24     ` Jeff Garzik
2004-01-13  0:25       ` Adrian Bunk
2004-01-13  9:57       ` Christoph Hellwig
2004-01-13 10:51         ` viro
2004-01-12  2:10   ` [2.4 patch] simplify PARPORT_PC_PCMCIA dependencies Adrian Bunk
2004-01-13  0:58   ` Adrian Bunk [this message]
2003-12-31 18:51 ` Iostats reporting problems was: Linux 2.4.24-pre3 Mike Fedyk
2004-01-13  1:42   ` Rick Lindsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040113005857.GY9677@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=andreas@xss.co.at \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox