From: James Cleverdon <jamesclv@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Cc: Chris McDermott <lcm@us.ibm.com>, "Martin J. Bligh" <mbligh@aracnet.com>
Subject: [PATCH] 2.6.1-mm2: Get irq_vector size right for generic subarch UP installer kernels
Date: Tue, 13 Jan 2004 16:26:59 -0800 [thread overview]
Message-ID: <200401131627.02138.jamesclv@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Problem: Earlier I didn't consider the case of the generic sub-arch and
uni-proc installer kernels used by a number of distros. It currently is
scaled by NR_CPUS. The correct values should be big for summit and generic,
and can stay the same for all others.
diff -pru 2.6.1-mm2/include/asm-i386/mach-default/irq_vectors.h
t1mm2/include/asm-i386/mach-default/irq_vectors.h
--- 2.6.1-mm2/include/asm-i386/mach-default/irq_vectors.h 2004-01-08
22:59:19.000000000 -0800
+++ t1mm2/include/asm-i386/mach-default/irq_vectors.h 2004-01-13
13:43:56.000000000 -0800
@@ -90,8 +90,12 @@
#else
#ifdef CONFIG_X86_IO_APIC
#define NR_IRQS 224
-# if (224 >= 32 * NR_CPUS)
-# define NR_IRQ_VECTORS NR_IRQS
+/*
+ * For Summit or generic (i.e. installer) kernels, we have lots of I/O APICs,
+ * even with uni-proc kernels, so use a big array.
+ */
+# if defined(CONFIG_X86_SUMMIT) || defined(CONFIG_X86_GENERICARCH)
+# define NR_IRQ_VECTORS 1024
# else
# define NR_IRQ_VECTORS (32 * NR_CPUS)
# endif
[-- Attachment #2: irq_vector_2004-01-13_2.6.1-mm2 --]
[-- Type: text/x-diff, Size: 728 bytes --]
diff -pru 2.6.1-mm2/include/asm-i386/mach-default/irq_vectors.h t1mm2/include/asm-i386/mach-default/irq_vectors.h
--- 2.6.1-mm2/include/asm-i386/mach-default/irq_vectors.h 2004-01-08 22:59:19.000000000 -0800
+++ t1mm2/include/asm-i386/mach-default/irq_vectors.h 2004-01-13 13:43:56.000000000 -0800
@@ -90,8 +90,12 @@
#else
#ifdef CONFIG_X86_IO_APIC
#define NR_IRQS 224
-# if (224 >= 32 * NR_CPUS)
-# define NR_IRQ_VECTORS NR_IRQS
+/*
+ * For Summit or generic (i.e. installer) kernels, we have lots of I/O APICs,
+ * even with uni-proc kernels, so use a big array.
+ */
+# if defined(CONFIG_X86_SUMMIT) || defined(CONFIG_X86_GENERICARCH)
+# define NR_IRQ_VECTORS 1024
# else
# define NR_IRQ_VECTORS (32 * NR_CPUS)
# endif
next reply other threads:[~2004-01-14 0:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 0:26 James Cleverdon [this message]
2004-01-14 1:00 ` [PATCH] 2.6.1-mm2: Get irq_vector size right for generic subarch UP installer kernels Zwane Mwaikambo
2004-01-14 19:59 ` James Cleverdon
2004-01-14 22:22 ` Zwane Mwaikambo
-- strict thread matches above, loose matches on Subject: below --
2004-01-14 19:34 James Bottomley
2004-01-14 20:01 ` James Cleverdon
2004-01-14 21:49 ` James Bottomley
2004-01-14 21:50 Nakajima, Jun
2004-01-14 22:20 ` Zwane Mwaikambo
2004-01-14 23:13 Nakajima, Jun
2004-01-15 4:36 ` Zwane Mwaikambo
2004-01-15 21:57 ` James Cleverdon
2004-01-15 22:40 ` Zwane Mwaikambo
2004-01-16 5:45 ` William Lee Irwin III
2004-01-15 22:42 ` Mika Penttilä
2004-01-16 2:35 Nakajima, Jun
2004-01-18 19:06 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401131627.02138.jamesclv@us.ibm.com \
--to=jamesclv@us.ibm.com \
--cc=akpm@osdl.org \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox