From: Matt Mackall <mpm@selenic.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-kernel@vger.kernel.org, pavel@suse.cz, amitkale@emsyssoft.com
Subject: Re: netpoll bug - kgdboe on x86_64
Date: Tue, 13 Jan 2004 19:04:18 -0600 [thread overview]
Message-ID: <20040114010418.GD28521@waste.org> (raw)
In-Reply-To: <20040114001830.60F5DC60FC@h00e098094f32.ne.client2.attbi.com>
On Tue, Jan 13, 2004 at 07:18:30PM -0500, Jim Houston wrote:
>
> Hi Matt,
Jim, fix your email address, you sent that as Jim Houston <jhouston@new.localdomain>.
> I'm trying to get kgdboe working on x86_64. I noticed that
> netpoll_rx is calling the rx_hook with negative values for the length.
> The attached patch fixes the problem.
This patch looks correct. I can't recall what I was thinking when I
tossed the -4 in there. It looks suspiciously like I did it to
mindlessly compensate for a bug where I took the sizeof a pointer
rather than a type, but I would _never_ do that. I'll send this on to
jgarzik who's queueing netpoll stuff for me.
> Jim Houston - Concurrent Computer Corp.
>
>
> +++ 2.6.1-rc1-mm2/net/core/netpoll.c 2004-01-13 18:58:09.311479928 -0500
> @@ -400,7 +400,7 @@ int netpoll_rx(struct sk_buff *skb)
>
> if (np->rx_hook)
> np->rx_hook(np, ntohs(uh->source),
> - (char *)(uh+1), ulen-sizeof(uh)-4);
> + (char *)(uh+1), ulen-sizeof(struct udphdr));
>
> return 1;
> }
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
prev parent reply other threads:[~2004-01-14 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 0:18 netpoll bug - kgdboe on x86_64 Jim Houston
2004-01-14 0:26 ` Pavel Machek
2004-01-14 1:04 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040114010418.GD28521@waste.org \
--to=mpm@selenic.com \
--cc=amitkale@emsyssoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox