From: Andrew Morton <akpm@osdl.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: marcelo.tosatti@cyclades.com, davem@redhat.com,
linux-kernel@vger.kernel.org, sim@netnation.com,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: Linux 2.4.25-pre5
Date: Fri, 16 Jan 2004 00:45:16 -0800 [thread overview]
Message-ID: <20040116004516.5fea2995.akpm@osdl.org> (raw)
In-Reply-To: <1074239098.31120.27.camel@imladris.demon.co.uk>
David Woodhouse <dwmw2@infradead.org> wrote:
>
> ===== fs/inode.c 1.48 vs edited =====
> --- 1.48/fs/inode.c Wed Jan 14 20:51:18 2004
> +++ edited/fs/inode.c Fri Jan 16 07:43:14 2004
> @@ -96,6 +96,7 @@
> if (inode) {
> struct address_space * const mapping = &inode->i_data;
>
> + init_waitqueue_head(&inode->i_wait);
> inode->i_sb = sb;
> inode->i_dev = sb->s_dev;
> inode->i_blkbits = sb->s_blocksize_bits;
> @@ -147,7 +148,6 @@
>
> void __inode_init_once(struct inode *inode)
> {
> - init_waitqueue_head(&inode->i_wait);
> INIT_LIST_HEAD(&inode->i_hash);
> INIT_LIST_HEAD(&inode->i_data.clean_pages);
> INIT_LIST_HEAD(&inode->i_data.dirty_pages);
Really, the init_waitqueue_head() should be done prior to putting the inode
back into slab.
next prev parent reply other threads:[~2004-01-16 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 20:19 Linux 2.4.25-pre5 Marcelo Tosatti
2004-01-15 22:55 ` David S. Miller
2004-01-15 23:12 ` Arnaldo Carvalho de Melo
2004-01-15 23:01 ` David S. Miller
2004-01-15 23:23 ` Arnaldo Carvalho de Melo
2004-01-15 23:23 ` Marcelo Tosatti
2004-01-16 7:44 ` David Woodhouse
2004-01-16 8:45 ` Andrew Morton [this message]
2004-01-16 8:58 ` David Woodhouse
2004-01-19 15:15 ` Geert Uytterhoeven
2004-02-02 15:39 ` [PATCH] fs/inode.c warning if !HIGHMEM (was: Re: Linux 2.4.25-pre5) Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116004516.5fea2995.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=sim@netnation.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox