From: Christoph Hellwig <hch@infradead.org>
To: Prashanth T <prasht@in.ibm.com>
Cc: rml@tech9.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rwlock_is_locked undefined for UP systems
Date: Fri, 16 Jan 2004 14:09:33 +0000 [thread overview]
Message-ID: <20040116140933.C24102@infradead.org> (raw)
In-Reply-To: <4007EAE7.2030104@in.ibm.com>; from prasht@in.ibm.com on Fri, Jan 16, 2004 at 07:15:11PM +0530
On Fri, Jan 16, 2004 at 07:15:11PM +0530, Prashanth T wrote:
> Hi,
> I had to use rwlock_is_locked( ) with linux2.6 for kdb and noticed that
> this routine to be undefined for UP. I have attached the patch for 2.6.1
> below to return 0 for rwlock_is_locked( ) on UP systems.
> Please let me know.
we don't implement spin_is_locked on UP either because there's no really
usefull return value. The lock will never be taken on !SMP && !PREEMPT,
but OTOH it's also not needed, so any assert on will give false results.
And the assert is probably the only thing that the _is_locked routines
could used for sanely.
next prev parent reply other threads:[~2004-01-16 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-16 13:45 [PATCH] rwlock_is_locked undefined for UP systems Prashanth T
2004-01-16 13:55 ` Arjan van de Ven
2004-01-16 14:53 ` Joe Thornber
2004-01-16 15:14 ` Nikita Danilov
2004-01-16 18:10 ` Mike Fedyk
2004-01-16 14:09 ` Christoph Hellwig [this message]
2004-01-19 6:12 ` Prashanth T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116140933.C24102@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasht@in.ibm.com \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox