From: Christoph Hellwig <hch@infradead.org>
To: Pat Gefre <pfg@sgi.com>
Cc: akpm@osdl.org, davidm@napali.hpl.hp.com,
linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 2.6] Altix updates
Date: Fri, 16 Jan 2004 14:41:32 +0000 [thread overview]
Message-ID: <20040116144132.A24555@infradead.org> (raw)
In-Reply-To: <200401152154.i0FLscIG023452@fsgi900.americas.sgi.com>; from pfg@sgi.com on Thu, Jan 15, 2004 at 03:54:37PM -0600
On Thu, Jan 15, 2004 at 03:54:37PM -0600, Pat Gefre wrote:
> 001-reorg.patch
> 002-reorg1.patch
The IS_IOADDR() stuff in the accesor funcs in pcibr_reg.c is completly
bogus, please decide whether you want to pass a pointer to the pcibr_soft
or bridge_t to it instead of doing second-guessing.
Also while the pic.h changes look okay they will conflict with a patch
I'm about to send that adds common headers for the bridge/xbow/xwidget
register for mips and IA64. Can you send me a version of pic.h with
those changes and the big endian ifdefs back in so I can just incorporate
the new version into my patch?
Also are all those access you abstract away different in TIOCP? If not
please don't add the wrappers for them.
next prev parent reply other threads:[~2004-01-16 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 21:54 [PATCH 2.6] Altix updates Pat Gefre
2004-01-16 2:34 ` Andrew Morton
2004-01-16 14:41 ` Christoph Hellwig [this message]
2004-01-20 17:50 ` Patrick Gefre
2004-01-20 18:08 ` Christoph Hellwig
2004-01-20 20:12 ` Patrick Gefre
2004-01-20 20:21 ` Christoph Hellwig
2004-01-20 22:23 ` Patrick Gefre
2004-01-20 23:34 ` Christoph Hellwig
2004-01-21 0:23 ` Patrick Gefre
2004-01-21 0:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116144132.A24555@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox