From: Christoph Hellwig <hch@infradead.org>
To: Doug Ledford <dledford@redhat.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
Arjan Van de Ven <arjanv@redhat.com>,
Martin Peschke3 <MPESCHKE@de.ibm.com>, Jens Axboe <axboe@suse.de>,
Peter Yao <peter@exavio.com.cn>,
linux-kernel@vger.kernel.org,
linux-scsi mailing list <linux-scsi@vger.kernel.org>,
ihno@suse.de
Subject: Re: smp dead lock of io_request_lock/queue_lock patch
Date: Sat, 17 Jan 2004 19:17:04 +0000 [thread overview]
Message-ID: <20040117191704.A6344@infradead.org> (raw)
In-Reply-To: <1074366452.13198.48.camel@compaq.xsintricity.com>; from dledford@redhat.com on Sat, Jan 17, 2004 at 02:07:33PM -0500
On Sat, Jan 17, 2004 at 02:07:33PM -0500, Doug Ledford wrote:
> #ifdef SCSI_HAS_HOST_LOCK
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0)
> adapter->lock_ptr = &adapter->lock;
> host->lock = &adapter->lock;
> #else
> adapter->lock_ptr = &adapter->lock;
> host->host_lock = &adapter->lock;
> #endif
> #else
> adapter->lock_ptr = &io_request_lock;
> #endif
Still looks wrong for the 2.6 case which should just be;
adapter->lock_ptr = shost->host_lock;
as I just stated in the review for the megaraid update.
next prev parent reply other threads:[~2004-01-17 19:17 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 15:07 smp dead lock of io_request_lock/queue_lock patch Martin Peschke3
2004-01-12 15:12 ` Arjan van de Ven
2004-01-12 19:48 ` Christoph Hellwig
2004-01-12 19:51 ` Doug Ledford
2004-01-12 20:03 ` Christoph Hellwig
2004-01-12 21:12 ` Jens Axboe
2004-01-13 20:55 ` Marcelo Tosatti
2004-01-17 13:10 ` Doug Ledford
2004-01-17 16:58 ` Christoph Hellwig
2004-01-17 19:07 ` Doug Ledford
2004-01-17 19:17 ` Christoph Hellwig [this message]
2004-01-17 19:21 ` Doug Ledford
2004-01-17 19:29 ` Christoph Hellwig
2004-01-17 20:36 ` Doug Ledford
2004-01-20 7:53 ` Jens Axboe
2004-01-20 2:19 ` [2.4] scsi per-host lock was " Marcelo Tosatti
2004-01-20 3:21 ` Doug Ledford
2004-01-25 0:31 ` Kurt Garloff
2004-01-15 17:17 ` Bill Davidsen
2004-01-17 13:12 ` Doug Ledford
2004-01-17 15:16 ` Bill Davidsen
2004-01-17 16:07 ` Doug Ledford
-- strict thread matches above, loose matches on Subject: below --
2004-01-19 21:36 Martin Peschke3
2004-03-08 21:25 ` Doug Ledford
[not found] <1d6yN-6HH-17@gated-at.bofh.it>
[not found] ` <1dasC-5Ww-5@gated-at.bofh.it>
[not found] ` <1ejkf-724-13@gated-at.bofh.it>
[not found] ` <1elvB-Jt-25@gated-at.bofh.it>
2004-01-16 15:40 ` Bill Davidsen
2004-01-12 16:32 Peter Yao
2004-01-12 9:08 ` Arjan van de Ven
2004-01-12 9:19 ` Jens Axboe
2004-01-12 9:19 ` Jens Axboe
2004-01-12 9:20 ` Arjan van de Ven
2004-01-12 9:22 ` Jens Axboe
2004-01-12 13:27 ` Doug Ledford
2004-01-15 17:01 ` Bill Davidsen
2004-01-15 17:05 ` Jens Axboe
2004-01-15 17:09 ` Arjan van de Ven
2004-01-15 19:30 ` Doug Ledford
2004-01-12 14:07 Martin Peschke3
2004-01-12 14:11 ` Arjan van de Ven
2004-01-12 14:13 ` Jens Axboe
2004-01-12 15:08 ` Doug Ledford
2004-01-12 15:24 ` James Bottomley
2004-01-12 15:43 ` Jens Axboe
2004-01-12 15:52 ` Doug Ledford
2004-01-12 16:04 ` James Bottomley
2004-01-12 16:05 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040117191704.A6344@infradead.org \
--to=hch@infradead.org \
--cc=MPESCHKE@de.ibm.com \
--cc=arjanv@redhat.com \
--cc=axboe@suse.de \
--cc=dledford@redhat.com \
--cc=ihno@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=peter@exavio.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox