From: viro@parcelfarce.linux.theplanet.co.uk
To: David Woodhouse <dwmw2@infradead.org>
Cc: Manfred Spraul <manfred@colorfullife.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] kill sleep_on
Date: Sat, 17 Jan 2004 20:10:00 +0000 [thread overview]
Message-ID: <20040117201000.GL21151@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1074367701.9965.2.camel@imladris.demon.co.uk>
On Sat, Jan 17, 2004 at 07:28:21PM +0000, David Woodhouse wrote:
> On Sat, 2004-01-17 at 19:43 +0100, Manfred Spraul wrote:
> > Virtually all sleep_on / interruptible_sleep_on users are racy. Actually
> > there is only one safe case: if both wakeup and sleep happen under
> > lock_kernel.
> > Any objections against killing it entirely? Or what about marking it as
> > deprecated, as the first step towards killing it?
> >
> > I'll follow with two patches that remove it from shaper and sunrpc/sched
> > - shaper is racy, rpciod_down is only safe if called with lock_kernel.
>
> Deprecate it in 2.7.0 and add BUG_ON(BKL not held) to it. Not before
> time.
We need to remove racy uses anyway - that can't wait for 2.7. And I really
wonder if there will be anything left after that - right now only reiserfs
uses look like something that might be not immediately broken.
AFAICS, _all_ uses of sleep_on() in drivers are broken in one way or another
and BKL won't help them.
next prev parent reply other threads:[~2004-01-17 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-17 18:43 [RFC] kill sleep_on Manfred Spraul
2004-01-17 19:19 ` Arjan van de Ven
2004-01-17 19:28 ` David Woodhouse
2004-01-17 20:10 ` viro [this message]
2004-01-17 23:18 ` Trond Myklebust
2004-01-17 23:45 ` David Woodhouse
2004-01-18 6:41 ` Andrew Morton
2004-01-18 6:57 ` Trond Myklebust
2004-01-18 7:05 ` Trond Myklebust
2004-01-18 7:36 ` Andrew Morton
2004-01-18 7:44 ` Manfred Spraul
2004-01-18 8:03 ` Trond Myklebust
2004-01-18 8:18 ` Manfred Spraul
2004-01-18 17:07 ` Trond Myklebust
2004-01-18 7:54 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040117201000.GL21151@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox