From: Tomas Szepe <szepe@pinerecords.com>
To: Romain Lievin <romain@rlievin.dyndns.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] "gconfig" removed root folder...
Date: Sun, 18 Jan 2004 08:24:36 +0100 [thread overview]
Message-ID: <20040118072435.GA9017@louise.pinerecords.com> (raw)
In-Reply-To: <20040117214756.GA30465@rlievin.dyndns.org>
On Jan-17 2004, Sat, 22:47 +0100
Romain Lievin <romain@rlievin.dyndns.org> wrote:
> > On Jan-15 2004, Thu, 22:44 +0100
> > Romain Lievin <romain@rlievin.dyndns.org> wrote:
> >
> > > + if(stat(fn, &sb) == -1) return;
> >
> > Codingstyle inconsistency.
>
> What should I write then ? Your piece of advice may make me better.
Read Documentation/CodingStyle. It is loosely based on the original
K&R style, where (the scarce) language constructs' arguments' opening
parenthese is prepended by a space, whereas with functions and macros
it is not. I.e., one writes 'if (...)', 'while (...)', 'foo(bar)', etc.
Also, your explicit casts could use extra whitespace, like so:
"a = (int *) b;" not "a = (int *)b;"
When submiting code to an existing file, the general rule of thumb
is not to disrupt the style of that particular file, regardless
of what it appears to be. You have managed to break this rule
_and_ the official CodingStyle.
--
Tomas Szepe <szepe@pinerecords.com>
next prev parent reply other threads:[~2004-01-18 7:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 14:36 True story: "gconfig" removed root folder Ozan Eren Bilgen
2004-01-15 15:05 ` Roman Zippel
2004-01-15 15:20 ` Doug McNaught
2004-01-15 15:37 ` Erik Hensema
2004-01-15 16:07 ` Tim Cambrant
2004-01-15 16:17 ` Valdis.Kletnieks
2004-01-15 18:31 ` Tim Cambrant
2004-01-15 18:49 ` Valdis.Kletnieks
2004-01-15 19:00 ` Richard B. Johnson
2004-01-15 19:30 ` Valdis.Kletnieks
2004-01-15 19:48 ` Erik Hensema
2004-01-17 16:47 ` Alban Browaeys
2004-01-16 17:20 ` Max Valdez
2004-01-15 21:23 ` Romain Lievin
2004-01-15 21:46 ` Roman Zippel
2004-01-15 22:00 ` Andreas Tolfsen
2004-01-15 22:56 ` Roman Zippel
2004-01-16 6:39 ` Andreas Tolfsen
2004-01-16 7:43 ` Romain Lievin
2004-01-16 21:18 ` Doug McNaught
2004-01-16 21:44 ` Roman Zippel
2004-01-18 12:59 ` Romain Lievin
2004-01-15 15:40 ` viro
2004-01-15 16:01 ` Jan-Benedict Glaw
2004-01-15 21:05 ` Romain Lievin
2004-01-15 21:44 ` [PATCH] " Romain Lievin
2004-01-16 20:17 ` [PATCH] Bug in patch of Romain: " oebilgen
2004-01-16 20:32 ` [PATCH] Bug in patch of Romain: "gconfig" remo ved r=?iso-8859-9?Q?Romain: "gconfig" removed=A0root=A0folder..._?= (part 2) oebilgen
2004-01-16 21:56 ` [PATCH] "gconfig" removed root folder Roman Zippel
[not found] ` <20040116161440.GC30349@louise.pinerecords.com>
2004-01-17 21:47 ` Romain Lievin
2004-01-18 7:24 ` Tomas Szepe [this message]
2004-01-18 14:21 ` True story: " Romain Lievin
2004-01-18 14:32 ` Muli Ben-Yehuda
2004-01-21 19:54 ` [PATCH] " Romain Lievin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040118072435.GA9017@louise.pinerecords.com \
--to=szepe@pinerecords.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romain@rlievin.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox