public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arkadiusz Miskiewicz <arekm@pld-linux.org>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Witold Krecicki <adasi@kernel.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix/improve modular IDE (Re: [PATCH] modular IDE for 2.6.1 ugly but working fix)
Date: Sun, 18 Jan 2004 12:52:49 +0100	[thread overview]
Message-ID: <200401181252.49861.arekm@pld-linux.org> (raw)
In-Reply-To: <200401171702.35705.bzolnier@elka.pw.edu.pl>

Dnia sob 17. stycznia 2004 17:02, Bartlomiej Zolnierkiewicz napisał:
> On Saturday 17 of January 2004 16:38, Sam Ravnborg wrote:
> > > +ide-core-objs += ide.o ide-default.o ide-io.o ide-iops.o ide-lib.o \
> > > +	ide-probe.o ide-taskfile.o
> >
> > It would be more consistent to use "ide-core-y" since this is
> > what the following lines are expanded to.
> >
> > > +
> > > +ide-core-$(CONFIG_BLK_DEV_CMD640)	+= pci/cmd640.o
> >
> > Like this line.
>
> Yep, thanks!
Could you send updated patch so we could test it?

Also would be nice if ide-detect name was used instead of ide-generic so it 
will be consistent with 2.4 naming.

ps. patch by Witold Krecicki works for other drivers - I've seen it working - 
but it's hacky anyway.
-- 
Arkadiusz Miśkiewicz    CS at FoE, Wroclaw University of Technology
arekm.pld-linux.org AM2-6BONE, 1024/3DB19BBD, arekm(at)ircnet, PLD/Linux

  reply	other threads:[~2004-01-18 11:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-17 12:13 [PATCH] modular IDE for 2.6.1 ugly but working fix Witold Krecicki
2004-01-17 13:22 ` [PATCH] fix/improve modular IDE (Re: [PATCH] modular IDE for 2.6.1 ugly but working fix) Bartlomiej Zolnierkiewicz
2004-01-17 15:38   ` Sam Ravnborg
2004-01-17 16:02     ` Bartlomiej Zolnierkiewicz
2004-01-18 11:52       ` Arkadiusz Miskiewicz [this message]
2004-01-18 12:25         ` Sam Ravnborg
2004-01-18 12:56         ` Bartlomiej Zolnierkiewicz
2004-01-20  2:01   ` Rusty Russell
2004-01-20 15:45     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200401181252.49861.arekm@pld-linux.org \
    --to=arekm@pld-linux.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=adasi@kernel.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox