From: Gerd Knorr <kraxel@bytesex.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel List <linux-kernel@vger.kernel.org>
Subject: [patch] new module args for ir-kbd-*.c
Date: Tue, 20 Jan 2004 13:44:52 +0100 [thread overview]
Message-ID: <20040120124452.GA19988@bytesex.org> (raw)
In-Reply-To: <20040120093054.GC18096@bytesex.org>
> On Tue, Jan 20, 2004 at 12:55:39PM +1100, Rusty Russell wrote:
> > Please replace the MODULE_PARM lines with the modern form:
> >
> > module_param(repeat, bool, 0644);
> > module_param(debug, int, 0644);
>
> I'll do for the bttv ir support, that is 2.6 only anyway due to the
> usage of tasklets.
Here we go.
Gerd
==============================[ cut here ]==============================
diff -u linux-2.6.1-mm5/drivers/media/video/ir-kbd-i2c.c linux/drivers/media/video/ir-kbd-i2c.c
--- linux-2.6.1-mm5/drivers/media/video/ir-kbd-i2c.c 2004-01-20 12:59:51.491270352 +0100
+++ linux/drivers/media/video/ir-kbd-i2c.c 2004-01-20 13:03:04.982855160 +0100
@@ -25,6 +25,7 @@
*/
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/sched.h>
@@ -55,8 +56,7 @@
/* ----------------------------------------------------------------------- */
/* insmod parameters */
-static int debug = 0; /* debug level (0,1,2) */
-MODULE_PARM(debug,"i");
+module_param(debug, int, 0644); /* debug level (0,1,2) */
#define DEVNAME "ir-kbd-i2c"
#define dprintk(level, fmt, arg...) if (debug >= level) \
diff -u linux-2.6.1-mm5/drivers/media/video/ir-kbd-gpio.c linux/drivers/media/video/ir-kbd-gpio.c
--- linux-2.6.1-mm5/drivers/media/video/ir-kbd-gpio.c 2004-01-20 12:59:51.490270504 +0100
+++ linux/drivers/media/video/ir-kbd-gpio.c 2004-01-20 13:03:05.080840264 +0100
@@ -18,6 +18,7 @@
*/
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/input.h>
#include <linux/delay.h>
@@ -170,8 +171,7 @@
struct timer_list timer;
};
-static int debug = 0; /* debug level (0,1,2) */
-MODULE_PARM(debug,"i");
+module_param(debug, int, 0644); /* debug level (0,1,2) */
#define DEVNAME "ir-kbd-gpio"
#define dprintk(fmt, arg...) if (debug) \
next prev parent reply other threads:[~2004-01-20 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 11:56 [patch] v4l-05 add infrared remote support Gerd Knorr
2004-01-15 14:26 ` Roman Zippel
2004-01-15 15:20 ` Gerd Knorr
2004-01-15 16:32 ` Roman Zippel
2004-01-20 1:55 ` Rusty Russell
2004-01-20 9:30 ` Gerd Knorr
2004-01-20 12:44 ` Gerd Knorr [this message]
2004-01-21 0:26 ` Rusty Russell
2004-01-21 3:49 ` Rusty Russell
2004-01-21 9:59 ` Gerd Knorr
2004-01-22 1:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040120124452.GA19988@bytesex.org \
--to=kraxel@bytesex.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox