* [patch] -mm5 has no i2c on amd64
@ 2004-01-20 12:46 Gerd Knorr
2004-01-20 17:10 ` Andrew Morton
2004-01-20 18:18 ` Andrew Morton
0 siblings, 2 replies; 9+ messages in thread
From: Gerd Knorr @ 2004-01-20 12:46 UTC (permalink / raw)
To: Andrew Morton, Kernel List
Hi,
trivial fix ...
Gerd
==============================[ cut here ]==============================
--- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
+++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
@@ -429,6 +429,8 @@
source "drivers/char/Kconfig"
+source "drivers/i2c/Kconfig"
+
source "drivers/misc/Kconfig"
source "drivers/media/Kconfig"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 12:46 [patch] -mm5 has no i2c on amd64 Gerd Knorr
@ 2004-01-20 17:10 ` Andrew Morton
2004-01-20 18:11 ` Sam Ravnborg
2004-01-20 18:18 ` Andrew Morton
1 sibling, 1 reply; 9+ messages in thread
From: Andrew Morton @ 2004-01-20 17:10 UTC (permalink / raw)
To: Gerd Knorr; +Cc: linux-kernel
Gerd Knorr <kraxel@bytesex.org> wrote:
>
> Hi,
>
> trivial fix ...
>
> Gerd
>
> ==============================[ cut here ]==============================
> --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> @@ -429,6 +429,8 @@
>
> source "drivers/char/Kconfig"
>
> +source "drivers/i2c/Kconfig"
> +
> source "drivers/misc/Kconfig"
>
Ah-hah! That's why the ppc64 kbuild system is whining about undefined but
used i2c symbols:
drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols
drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
So this change needs to be propagated to other architectures as well.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 17:10 ` Andrew Morton
@ 2004-01-20 18:11 ` Sam Ravnborg
0 siblings, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2004-01-20 18:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: Gerd Knorr, linux-kernel
On Tue, Jan 20, 2004 at 09:10:35AM -0800, Andrew Morton wrote:
> > Hi,
> >
> > trivial fix ...
> >
> > Gerd
> >
> > ==============================[ cut here ]==============================
> > --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > @@ -429,6 +429,8 @@
> >
> > source "drivers/char/Kconfig"
> >
> > +source "drivers/i2c/Kconfig"
> > +
> > source "drivers/misc/Kconfig"
> >
>
> Ah-hah! That's why the ppc64 kbuild system is whining about undefined but
> used i2c symbols:
>
> drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols
> drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
>
> So this change needs to be propagated to other architectures as well.
The better approach is to use the generic drivers/Kconfig,
as used by i386, parisc and cris today.
Sam
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 12:46 [patch] -mm5 has no i2c on amd64 Gerd Knorr
2004-01-20 17:10 ` Andrew Morton
@ 2004-01-20 18:18 ` Andrew Morton
1 sibling, 0 replies; 9+ messages in thread
From: Andrew Morton @ 2004-01-20 18:18 UTC (permalink / raw)
To: Gerd Knorr; +Cc: linux-kernel
Gerd Knorr <kraxel@bytesex.org> wrote:
>
> Hi,
>
> trivial fix ...
>
> Gerd
>
> ==============================[ cut here ]==============================
> --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> @@ -429,6 +429,8 @@
>
> source "drivers/char/Kconfig"
>
> +source "drivers/i2c/Kconfig"
> +
> source "drivers/misc/Kconfig"
>
> source "drivers/media/Kconfig"
Apparently architectures should be sourcing the generic drivers/Kconfig
file. But let's run with your fix for now.
^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20040120124626.GA20023@bytesex.org.suse.lists.linux.kernel>]
* Re: [patch] -mm5 has no i2c on amd64
[not found] <20040120124626.GA20023@bytesex.org.suse.lists.linux.kernel>
@ 2004-01-20 12:59 ` Andi Kleen
2004-01-20 18:19 ` Andrew Morton
2004-01-20 18:32 ` Gerd Knorr
0 siblings, 2 replies; 9+ messages in thread
From: Andi Kleen @ 2004-01-20 12:59 UTC (permalink / raw)
To: Gerd Knorr; +Cc: linux-kernel
Gerd Knorr <kraxel@bytesex.org> writes:
>
> ==============================[ cut here ]==============================
> --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> @@ -429,6 +429,8 @@
>
> source "drivers/char/Kconfig"
>
> +source "drivers/i2c/Kconfig"
> +
There is no such source in arch/i386/Kconfig. So it's probably wrong.
-Andi
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 12:59 ` Andi Kleen
@ 2004-01-20 18:19 ` Andrew Morton
2004-01-20 18:32 ` Gerd Knorr
1 sibling, 0 replies; 9+ messages in thread
From: Andrew Morton @ 2004-01-20 18:19 UTC (permalink / raw)
To: Andi Kleen; +Cc: kraxel, linux-kernel
Andi Kleen <ak@suse.de> wrote:
>
> Gerd Knorr <kraxel@bytesex.org> writes:
> >
> > ==============================[ cut here ]==============================
> > --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > @@ -429,6 +429,8 @@
> >
> > source "drivers/char/Kconfig"
> >
> > +source "drivers/i2c/Kconfig"
> > +
>
> There is no such source in arch/i386/Kconfig. So it's probably wrong.
>
arch/i386/Kconfig sources drivers/Kconfig, which then picks up the i2c stuff.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 12:59 ` Andi Kleen
2004-01-20 18:19 ` Andrew Morton
@ 2004-01-20 18:32 ` Gerd Knorr
2004-01-20 18:51 ` Andi Kleen
1 sibling, 1 reply; 9+ messages in thread
From: Gerd Knorr @ 2004-01-20 18:32 UTC (permalink / raw)
To: Andi Kleen, Andrew Morton; +Cc: linux-kernel
On Tue, Jan 20, 2004 at 01:59:46PM +0100, Andi Kleen wrote:
> Gerd Knorr <kraxel@bytesex.org> writes:
> >
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > +source "drivers/i2c/Kconfig"
> > +
>
> There is no such source in arch/i386/Kconfig. So it's probably wrong.
i386 includes that indirectly via drivers/Kconfig
So should the other archs do that too?
Gerd
--
"... und auch das ganze Wochenende oll" -- Wetterbericht auf RadioEins
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 18:32 ` Gerd Knorr
@ 2004-01-20 18:51 ` Andi Kleen
2004-01-21 0:30 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Andi Kleen @ 2004-01-20 18:51 UTC (permalink / raw)
To: Gerd Knorr; +Cc: akpm, linux-kernel
On Tue, 20 Jan 2004 19:32:59 +0100
Gerd Knorr <kraxel@suse.de> wrote:
> On Tue, Jan 20, 2004 at 01:59:46PM +0100, Andi Kleen wrote:
> > Gerd Knorr <kraxel@bytesex.org> writes:
> > >
> > > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > > +source "drivers/i2c/Kconfig"
> > > +
> >
> > There is no such source in arch/i386/Kconfig. So it's probably wrong.
>
> i386 includes that indirectly via drivers/Kconfig
> So should the other archs do that too?
Yep. Or at least x86-64 should likely.
But it must have worked until recently because I got a report about I2C on x86-64 for 2.6.0.
-Andi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] -mm5 has no i2c on amd64
2004-01-20 18:51 ` Andi Kleen
@ 2004-01-21 0:30 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2004-01-21 0:30 UTC (permalink / raw)
To: Andi Kleen; +Cc: Gerd Knorr, akpm, linux-kernel
On Tue, Jan 20, 2004 at 07:51:32PM +0100, Andi Kleen wrote:
> On Tue, 20 Jan 2004 19:32:59 +0100
> Gerd Knorr <kraxel@suse.de> wrote:
>
> > On Tue, Jan 20, 2004 at 01:59:46PM +0100, Andi Kleen wrote:
> > > Gerd Knorr <kraxel@bytesex.org> writes:
> > > >
> > > > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > > > +source "drivers/i2c/Kconfig"
> > > > +
> > >
> > > There is no such source in arch/i386/Kconfig. So it's probably wrong.
> >
> > i386 includes that indirectly via drivers/Kconfig
> > So should the other archs do that too?
>
> Yep. Or at least x86-64 should likely.
>
> But it must have worked until recently because I got a report about I2C on x86-64 for 2.6.0.
Yes, I just moved the i2c Kconfig out of the char menu, and into the
main drivers/Kconfig.
And here I thought all of the archs had switched to using that file,
instead of trying to put together their own drivers menus :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2004-01-21 0:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-20 12:46 [patch] -mm5 has no i2c on amd64 Gerd Knorr
2004-01-20 17:10 ` Andrew Morton
2004-01-20 18:11 ` Sam Ravnborg
2004-01-20 18:18 ` Andrew Morton
[not found] <20040120124626.GA20023@bytesex.org.suse.lists.linux.kernel>
2004-01-20 12:59 ` Andi Kleen
2004-01-20 18:19 ` Andrew Morton
2004-01-20 18:32 ` Gerd Knorr
2004-01-20 18:51 ` Andi Kleen
2004-01-21 0:30 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox