From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@suse.cz>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: swsusp does not stop DMA properly during resume
Date: Tue, 20 Jan 2004 16:01:59 -0800 [thread overview]
Message-ID: <20040120160159.5cb078ec.akpm@osdl.org> (raw)
In-Reply-To: <20040120235347.GE1234@elf.ucw.cz>
Pavel Machek <pavel@suse.cz> wrote:
>
> Hi!
>
> > > I _think_ what this patch is doing is suspending all devices from within
> > > the boot kernel before starting into the resumed kernel. Is this correct?
> > >
> > > > + update_screen(fg_console); /* Hmm, is this the problem? */
> > >
> > > Cryptic comment. To what "problem" does this refer?
> >
> > Note that you should make sure all calls to update_screen (among others)
> > are guarded by the console semaphore, with my VT patch, not doing so
> > will result in WARN_ON's
>
> Hmmm... yes, I'll need to fix that one. [Is there console semaphore in
> 2.6.1, or do I need to wait for 2.6.2 before I can do something with
> this?]
It's acquire_console_sem()/release_console_sem().
I'll change the patch. Could you please test it all in next -mm, let me
know?
next prev parent reply other threads:[~2004-01-21 0:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 22:46 swsusp does not stop DMA properly during resume Pavel Machek
2004-01-20 23:06 ` Andrew Morton
2004-01-20 23:08 ` Pavel Machek
2004-01-20 23:40 ` Benjamin Herrenschmidt
2004-01-20 23:53 ` Pavel Machek
2004-01-21 0:01 ` Andrew Morton [this message]
2004-01-21 0:05 ` Pavel Machek
2004-01-21 0:09 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040120160159.5cb078ec.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox