From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Gerd Knorr <kraxel@bytesex.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] -mm5 has no i2c on amd64
Date: Tue, 20 Jan 2004 19:11:08 +0100 [thread overview]
Message-ID: <20040120181108.GC12912@mars.ravnborg.org> (raw)
In-Reply-To: <20040120091035.0fb7b3ee.akpm@osdl.org>
On Tue, Jan 20, 2004 at 09:10:35AM -0800, Andrew Morton wrote:
> > Hi,
> >
> > trivial fix ...
> >
> > Gerd
> >
> > ==============================[ cut here ]==============================
> > --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > @@ -429,6 +429,8 @@
> >
> > source "drivers/char/Kconfig"
> >
> > +source "drivers/i2c/Kconfig"
> > +
> > source "drivers/misc/Kconfig"
> >
>
> Ah-hah! That's why the ppc64 kbuild system is whining about undefined but
> used i2c symbols:
>
> drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols
> drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
>
> So this change needs to be propagated to other architectures as well.
The better approach is to use the generic drivers/Kconfig,
as used by i386, parisc and cris today.
Sam
next prev parent reply other threads:[~2004-01-20 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 12:46 [patch] -mm5 has no i2c on amd64 Gerd Knorr
2004-01-20 17:10 ` Andrew Morton
2004-01-20 18:11 ` Sam Ravnborg [this message]
2004-01-20 18:18 ` Andrew Morton
[not found] <20040120124626.GA20023@bytesex.org.suse.lists.linux.kernel>
2004-01-20 12:59 ` Andi Kleen
2004-01-20 18:19 ` Andrew Morton
2004-01-20 18:32 ` Gerd Knorr
2004-01-20 18:51 ` Andi Kleen
2004-01-21 0:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040120181108.GC12912@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox