Re: [Dri-devel] [2.6 patch] disallow DRM on 386

[Adrian Bunk <bunk@fs.tum.de>]

On Wed, Jan 21, 2004 at 12:04:59AM +0000, Alan Cox wrote:
> On Maw, 2004-01-20 at 21:24, Adrian Bunk wrote:
> > I got the following compile error in 2.6.1-mm5 with X86_CMPXCHG=n.
> > This problem is not specific to -mm, and it always occurs when you 
> > include support for the 386 cpu (oposed to the 486 or later cpus) since 
> > in this case X86_CMPXCHG=n and therefoore cmpxchg isn't defined in 
> > include/asm-i386/system.h .
> > 
> > The patch below disallows DRM if X86_CMPXCHG=n.
> 
> Ugly.
> 
> Fix system.h to always define cmpxchg.h and check its presence at
> runtime when the DRM module loads, then you can build 386 kernels that
> support DRI on higher machines.
> 
> The problem isnt that cmpxchg definitely doesn't exist, so system.h is
> wrong IMHO

???

AFAIR cmpxchg wasn't present in cpus earlier than the 486.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed