Re: [2.6 patch] disallow DRM on 386

[Adrian Bunk <bunk@fs.tum.de>]

On Tue, Jan 20, 2004 at 03:31:58PM -0800, Andrew Morton wrote:
> Adrian Bunk <bunk@fs.tum.de> wrote:
> >
> > On Tue, Jan 20, 2004 at 11:44:03PM +0100, Diego Calleja wrote:
> > > El Tue, 20 Jan 2004 22:24:21 +0100 Adrian Bunk <bunk@fs.tum.de> escribió:
> > > 
> > > > I got the following compile error in 2.6.1-mm5 with X86_CMPXCHG=n.
> > > > This problem is not specific to -mm, and it always occurs when you 
> > > > include support for the 386 cpu (oposed to the 486 or later cpus) since 
> > > > in this case X86_CMPXCHG=n and therefoore cmpxchg isn't defined in 
> > > > include/asm-i386/system.h .
> > > > 
> > > > The patch below disallows DRM if X86_CMPXCHG=n.
> > > 
> > > I got a "cmpxchg not defined" error when compiling the drm stuff in -mm5.
> > > When I looked at the configuration, I saw that all the cpus types had been selected
> > > (I didn't even realize of your stuuf and menuconfig put the defaults). I removed
> > > all types of cpus except PIII and it compiled.
> > 
> > Yup, that's exactly the problem.
> > 
> > Selecting CPU_386 in -mm4 or -mm5 or selecting M386 in other kernels 
> > triggers it.
> > 
> 
> I'll remove 386 from the default CPU types as well.

Thanks, this sounds reasonable.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed