Re: [BK PATCH] Driver Core update for 2.6.1

[Greg KH <greg@kroah.com>]

On Wed, Jan 21, 2004 at 02:59:07AM +0100, Måns Rullgård wrote:
> Greg KH <greg@kroah.com> writes:
> 
> > On Tue, Jan 20, 2004 at 06:48:50PM +0100, Måns Rullgård wrote:
> >> Greg KH <greg@kroah.com> writes:
> >> 
> >> > On Tue, Jan 20, 2004 at 09:40:22AM +0100, Måns Rullgård wrote:
> >> >> Greg KH <greg@kroah.com> writes:
> >> >> 
> >> >> >   o ALSA: add sysfs class support for ALSA sound devices
> >> >> 
> >> >> This is still only completed for the intel8x0 driver, right?
> >> >
> >> > The "device" and "driver" symlink will only show up for that driver,
> >> > yes.  But the class support will work for all alsa devices.  Now we can
> >> > add 1 line patches for all of the alsa drivers to enable those
> >> > symlinks...
> >> 
> >> I see.
> >> 
> >> BTW, I still don't get a snd/controlC0 in /udev.  All the other ALSA
> >> devices are there.
> >
> > Is there for me :)
> >
> > What does /sys/class/sound show for you?
> 
> $ ls /sys/class/sound
> pcmC0D0c  pcmC0D0p  pcmC0D1c  timer
> 
> FWIW, I've updated my kernel to ALSA 1.0.1 and merged your patches.

I don't know if any recent ALSA changes took away the controlC nodes,
but your sound/core/sound.c::alsa_sound_init() should have a line in it
that looks like:
	class_simple_device_add(sound_class, MKDEV(major, controlnum<<5), NULL, "controlC%d", controlnum);
and that should always get called (make sure you took the stupid 
#ifdef CONFIG_DEVFS around that for loop.)

I'm guessing you didn't merge quite right :)

thanks,

greg k-h