From: Rusty Russell <rusty@rustcorp.com.au>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] v4l-05 add infrared remote support
Date: Wed, 21 Jan 2004 11:26:03 +1100 [thread overview]
Message-ID: <20040121043608.7F1F02C141@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 20 Jan 2004 10:30:54 BST." <20040120093054.GC18096@bytesex.org>
In message <20040120093054.GC18096@bytesex.org> you write:
> On Tue, Jan 20, 2004 at 12:55:39PM +1100, Rusty Russell wrote:
> > In message <20040115115611.GA16266@bytesex.org> you write:
> > > +static int repeat = 1;
> > > +MODULE_PARM(repeat,"i");
> > > +MODULE_PARM_DESC(repeat,"auto-repeat for IR keys (default: on)");
> > > +
> > > +static int debug = 0; /* debug level (0,1,2) */
> > > +MODULE_PARM(debug,"i");
> >
> > Please replace the MODULE_PARM lines with the modern form:
> >
> > module_param(repeat, bool, 0644);
> > module_param(debug, int, 0644);
>
> No. The code in question must also build on 2.4 kernels which don't
> have module_param(). And I don't want to clutter up the code with
> #ifdefs unless I absolutely have to.
Sure! I'll write and test the forward compat macros for 2.4, submit
them to Marcelo, and then bother you again 8)
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2004-01-21 4:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 11:56 [patch] v4l-05 add infrared remote support Gerd Knorr
2004-01-15 14:26 ` Roman Zippel
2004-01-15 15:20 ` Gerd Knorr
2004-01-15 16:32 ` Roman Zippel
2004-01-20 1:55 ` Rusty Russell
2004-01-20 9:30 ` Gerd Knorr
2004-01-20 12:44 ` [patch] new module args for ir-kbd-*.c Gerd Knorr
2004-01-21 0:26 ` Rusty Russell [this message]
2004-01-21 3:49 ` [patch] v4l-05 add infrared remote support Rusty Russell
2004-01-21 9:59 ` Gerd Knorr
2004-01-22 1:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040121043608.7F1F02C141@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox