Re: More cleanups for swsusp

Andrew Morton
2004-01-21T05:30:13Z

Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> In message <20040120225219.GA19190@elf.ucw.cz> you write:
> > - if (fill_suspend_header(&cur->sh))
> > - panic("\nOut of memory while writing header");
> > + BUG_ON (fill_suspend_header(&cur->sh));
>
> ...
> 3) BUG_ON(complex condition expression) is much less clear than:
>
> if (complex condition expression)
> BUG();

Worse. If some smarty goes and makes BUG_ON a no-op (for space reasons),
it will break software suspend. We should ensure that the expression which
is supplied to BUG_ON() never has side-effects for this reason.

I'll drop that chunk.