Re: More cleanups for swsusp

Pavel Machek
2004-01-20T23:27:10Z

Hi!

> > + BUG_ON (sizeof(struct link) != PAGE_SIZE);
>
> Looking at the code, this hardly seems worth checking. But the compiler
> should just rub this code out anwyay, so whatever.
>
> hmm, one could do:
>
> #define compile_time_assert(expr) \
> do { \
> if (!(expr)) \
> compile_time_assert_failed(); /* undefined */ \
> } while (0)

Well, if you provide such macro, I'll be happy to use it ;-). It
should be something like

compile_time_assert(expr, "message")

because with more of these are in the code, it would be nightmare to
find out which one is wrong.

Perhaps better name, too?

pavel@elonex:/tmp$ cat delme.c

#define COMPILE_ERR_ON(expr, message) \
do { if (!(expr)) compile_time_assert_failed_##message(); } while (0)

void main(void)
{
COMPILE_ERR_ON(0==8, cpu_broke_zeros_neck);
COMPILE_ERR_ON(0==0, compiler_went_crazy);
}
pavel@elonex:/tmp$ gcc delme.c -o delme
delme.c: In function `main':
delme.c:6: warning: return type of `main' is not `int'
/tmp/ccAx2alr.o(.text+0x11): In function `main':
: undefined reference to `compile_time_assert_failed_cpu_broke_zeros_neck'
collect2: ld returned 1 exit status
pavel@elonex:/tmp$

Pavel

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]