public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jun Sun <jsun@mvista.com>
To: linux-kernel@vger.kernel.org
Cc: jsun@mvista.com
Subject: [BUG 2.6.1] missing 'console_driver' with CONFIG_VT but no CONFIG_VT_CONSOLE
Date: Wed, 21 Jan 2004 15:31:02 -0800	[thread overview]
Message-ID: <20040121153102.D29705@mvista.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]


See drivers/char/vt.c.

'console_driver' is defined only when CONFIG_VT_CONSOLE is set.
However it is used by vty_init() which is outside the scope
of CONFIG_VT_CONSOLE.

I think the fix is to move console_driver definition outside
CONFIG_VT_CONSOLE.  See the attachment.  Hopefully someone with
more knowledge on this can validate that.

Jun

[-- Attachment #2: junk --]
[-- Type: text/plain, Size: 496 bytes --]

diff -Nru drivers/char/vt.c.orig drivers/char/vt.c
--- drivers/char/vt.c.orig	Wed Nov  5 14:29:51 2003
+++ drivers/char/vt.c	Wed Jan 21 15:27:06 2004
@@ -2086,6 +2086,8 @@
 	schedule_console_callback();
 }
 
+struct tty_driver *console_driver;
+
 #ifdef CONFIG_VT_CONSOLE
 
 /*
@@ -2185,8 +2187,6 @@
 	clear_bit(0, &printing);
 }
 
-struct tty_driver *console_driver;
-
 static struct tty_driver *vt_console_device(struct console *c, int *index)
 {
 	*index = c->index ? c->index-1 : fg_console;

                 reply	other threads:[~2004-01-21 23:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040121153102.D29705@mvista.com \
    --to=jsun@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox