From: Rusty Russell <rusty@rustcorp.com.au>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] v4l-05 add infrared remote support
Date: Thu, 22 Jan 2004 12:05:00 +1100 [thread overview]
Message-ID: <20040122032941.262AD2C229@lists.samba.org> (raw)
In-Reply-To: Your message of "Wed, 21 Jan 2004 10:59:36 BST." <20040121095935.GA31624@bytesex.org>
In message <20040121095935.GA31624@bytesex.org> you write:
> > This provides simple forwards compat for 2.4. It doesn't do arrays or
> > strings, but they can be added if required (this will cover the easy
> > 90%).
>
> At least the array stuff I'm using in my drivers, to handle the
> "multiple tv cards in one box" case, like this:
>
> static unsigned int card[] = {[0 ... (SAA7134_MAXBOARDS - 1)] = UNSET };
> MODULE_PARM(card,"1-" __stringify(SAA7134_MAXBOARDS) "i");
> MODULE_PARM_DESC(card,"card type");
>
> So having that in 2.4 too would be nice.
Unfortunately the module_param_array() macro is not really fungible
into the old MODULE_PARM() macro: in particular the array size is now
implicit.
I could introduce another macro which could be #defined to both, but
for the moment I thought I'd see we get without one.
> I have also two more questions: How can I specify default values != 0
> for insmod options using the new macros?
Not sure I understand? You'd presumably do it like so:
int foo = 7;
MODULE_PARM(foo, "i"); / module_param(foo, int, 0600)
> How specify help/description
> texts? Using the MODULE_PARM_DESC() macro or is there something new too?
I didn't change it. I thought about it, but I think that would just
be neatening for the sake of neatening, which I dislike.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2004-01-22 3:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 11:56 [patch] v4l-05 add infrared remote support Gerd Knorr
2004-01-15 14:26 ` Roman Zippel
2004-01-15 15:20 ` Gerd Knorr
2004-01-15 16:32 ` Roman Zippel
2004-01-20 1:55 ` Rusty Russell
2004-01-20 9:30 ` Gerd Knorr
2004-01-20 12:44 ` [patch] new module args for ir-kbd-*.c Gerd Knorr
2004-01-21 0:26 ` [patch] v4l-05 add infrared remote support Rusty Russell
2004-01-21 3:49 ` Rusty Russell
2004-01-21 9:59 ` Gerd Knorr
2004-01-22 1:05 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040122032941.262AD2C229@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox