* [PATCH] Fix Careless bio->_bio change in rq_for_each_bio().
@ 2004-01-22 6:40 Rusty Russell
2004-01-22 10:30 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2004-01-22 6:40 UTC (permalink / raw)
To: torvalds, akpm; +Cc: linux-kernel
Looks like an obvious typo. Works fine if "bio" is the name of the
iterator.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.2-rc1/include/linux/blkdev.h tmp/include/linux/blkdev.h
--- linux-2.6.2-rc1/include/linux/blkdev.h 2004-01-21 16:19:05.000000000 +1100
+++ tmp/include/linux/blkdev.h 2004-01-22 17:38:52.000000000 +1100
@@ -485,7 +485,7 @@ static inline void blk_queue_bounce(requ
#define rq_for_each_bio(_bio, rq) \
if ((rq->bio)) \
- for (_bio = (rq)->bio; _bio; _bio = bio->bi_next)
+ for (_bio = (rq)->bio; _bio; _bio = _bio->bi_next)
struct sec_size {
unsigned block_size;
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix Careless bio->_bio change in rq_for_each_bio().
2004-01-22 6:40 [PATCH] Fix Careless bio->_bio change in rq_for_each_bio() Rusty Russell
@ 2004-01-22 10:30 ` Jens Axboe
2004-01-22 10:36 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2004-01-22 10:30 UTC (permalink / raw)
To: Rusty Russell; +Cc: torvalds, akpm, linux-kernel
On Thu, Jan 22 2004, Rusty Russell wrote:
> Looks like an obvious typo. Works fine if "bio" is the name of the
> iterator.
Rusty,
This was already posted a week or two ago, and has been in Linus' tree
since yesterday (or the day before).
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix Careless bio->_bio change in rq_for_each_bio().
2004-01-22 10:30 ` Jens Axboe
@ 2004-01-22 10:36 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2004-01-22 10:36 UTC (permalink / raw)
To: Rusty Russell; +Cc: torvalds, akpm, linux-kernel
On Thu, Jan 22 2004, Jens Axboe wrote:
> On Thu, Jan 22 2004, Rusty Russell wrote:
> > Looks like an obvious typo. Works fine if "bio" is the name of the
> > iterator.
>
> Rusty,
>
> This was already posted a week or two ago, and has been in Linus' tree
> since yesterday (or the day before).
Sorry misread that, there was an error in the fixup :)
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-22 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-22 6:40 [PATCH] Fix Careless bio->_bio change in rq_for_each_bio() Rusty Russell
2004-01-22 10:30 ` Jens Axboe
2004-01-22 10:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox