Re: 2.6.2-rc1-mm1

Andrew Morton
2004-01-22T21:33:37Z

Axel Siebenwirth <axel@pearbough.net> wrote:
>
> Hi!
>
> On Thu, 22 Jan 2004, Andrew Morton wrote:
>
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.2-rc1/2.6.2-rc1-mm1/
> >
> >
> > - Nothing very exciting, just lots of random fixes.
> >
> > - The x86 gcc-3.4/gcc-3.5 support seems pretty much complete now. There
> > are enough fixes here to get a reasonably clean build with my .config but a
> > full kernel build still will need work.
>
> In my case it is NTFS causing the build failure.
>
> CC fs/ntfs/inode.o
> fs/ntfs/inode.c: In function `ntfs_read_locked_inode':
> fs/ntfs/ntfs.h:186: sorry, unimplemented: inlining failed in call to
> 'ntfs2utc': function body not available

Yes, there are going to be a lot of these. Lots of code does

foo.h:
extern inline void foo(void);
foo.c:
inline void foo(void)
{
}

and latest gcc generates an error in this case (with the options we're
currently using, at least).

The fix is to remove the `inline' from the declaration in foo.h. It's the
right thing to do anyway, so I'm thinking we should just get in there and
fix them all up.