Re: 2.6.2-rc1-mm1

viro
2004-01-22T15:23:31Z

On Thu, Jan 22, 2004 at 11:03:42AM +0000, Christoph Hellwig wrote:
> > sysfs-class-06-raw.patch
> > From: Greg KH <greg@kroah.com>
> > Subject: [PATCH] add sysfs class support for raw devices [06/10]
>
> This one exports get_gendisk, which is a no-go.

Moreover, it obviously leaks references to struct gendisk _and_ changes
semantics of RAW_SETBIND in incompatible way.

Consider that vetoed. And yes, get_gendisk() issue alone would be enough.

Greg, please, RTFS to see at which point do we decide which driver will
be used by raw device. It's _not_ RAW_SETBIND, it's open(). So where
your symlink should point is undecided until the same point.