public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: grundler@parisc-linux.org
Cc: jgarzik@pobox.lackof.org, linux-kernel@vger.kernel.org,
	linux-net@vger.kernel.org
Subject: Re: [PATCH] 2.6.1 tg3 DMA engine test failure
Date: Fri, 23 Jan 2004 21:00:23 -0800 (PST)	[thread overview]
Message-ID: <20040123.210023.74723544.davem@redhat.com> (raw)
In-Reply-To: <20040124013614.GB1310@colo.lackof.org>

   From: Grant Grundler <grundler@parisc-linux.org>
   Date: Fri, 23 Jan 2004 18:36:14 -0700

   3) Broadcom engineer noted the meaning of DMA_RWCTRL_ASSERT_ALL_BE
      has changed for bcm570[34] and also advised against setting
      it on BCM570[01] chips. I'm just implementing his advice.
      Comment below spells out more details.

Setting this bit is absolutely required on many RISC PCI boxes, where
streaming mappings must have cacheline sized DMA transactions done
on them with all byte enables on.

In fact, since the later chips don't allow controlling this, some of
them cause streaming byte hole errors on sparc64 and other RISC
systems when they do cacheline sized DMA to streaming DMA mappings
with not all the byte enables on.

So I'm not going to add this part of your changes.

  reply	other threads:[~2004-01-24  5:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-24  1:36 [PATCH] 2.6.1 tg3 DMA engine test failure Grant Grundler
2004-01-24  5:00 ` David S. Miller [this message]
2004-01-24  7:30   ` Grant Grundler
2004-01-24  7:32     ` David S. Miller
2004-01-24 21:15       ` Jeff Garzik
2004-01-24 21:14         ` David S. Miller
2004-01-25  1:48         ` Grant Grundler
2004-01-25  1:53           ` Jeff Garzik
2004-01-25  5:31             ` Grant Grundler
2004-01-25  7:11               ` David S. Miller
2004-01-25  2:13       ` Grant Grundler
2004-01-26  7:52         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040123.210023.74723544.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=grundler@parisc-linux.org \
    --cc=jgarzik@pobox.lackof.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox