From: Dave Jones <davej@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: logic error in radeonfb.
Date: Fri, 23 Jan 2004 06:54:10 +0000 [thread overview]
Message-ID: <20040123065410.GF9327@redhat.com> (raw)
In-Reply-To: <1074840394.949.200.camel@gaston>
On Fri, Jan 23, 2004 at 05:46:35PM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2004-01-23 at 17:35, davej@redhat.com wrote:
> > Looks like another instance of a ! in the wrong place.
>
> Ohh, and _oooold_ bug fixed a long time ago in 2.4. There may actually
> be another occurence of this one elsewhere iirc. I'll check that.
Back then someone came up with a cool one-liner that grepped for
suspicious if's with !'s, it seems no-one ever did the same for 2.6,
as there were a few others (see seperate mails for patches).
> that this code is powermac specific anyway and that old radeonfb doesn't
> work very well on a lot of powermacs, so it's not very urgent. The new
> radeonfb which has that fixed for a long time will get in along with
> the fbdev updates as soon as I'm finished cleaning them up.
Ok, If this is going to make your merge more difficult, feel free to ignore it.
Dave
next prev parent reply other threads:[~2004-01-23 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 6:35 logic error in radeonfb davej
2004-01-23 6:46 ` Benjamin Herrenschmidt
2004-01-23 6:54 ` Dave Jones [this message]
2004-01-23 7:03 ` Benjamin Herrenschmidt
2004-01-23 11:24 ` John Levon
2004-01-23 13:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040123065410.GF9327@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox