From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Kernel development list <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@digitalimplant.org>
Subject: Re: PATCH: (as177) Add class_device_unregister_wait() and platform_device_unregister_wait() to the driver model core
Date: Fri, 23 Jan 2004 10:27:14 -0800 [thread overview]
Message-ID: <20040123182714.GF23169@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0401231017030.2151@home.osdl.org>
On Fri, Jan 23, 2004 at 10:19:15AM -0800, Linus Torvalds wrote:
>
>
> On Fri, 23 Jan 2004, Greg KH wrote:
> > >
> > > So why would this not deadlock?
> >
> > It will deadlock if the user does something braindead like:
> > rmmod foo < /sys/class/foo_class/foo1/file
>
> I don't much worry about things like that, since only root can rmmod
> anyway.
Yeah, that's why I didn't care very much either.
> HOWEVER - I do worry when people start exporting interfaces that are
> basically _designed_ to deadlock. It's a bad interface. Don't export it.
> There is possibly just _one_ place that can do it, and it's the module
> unload part. Everything else would be a bug.
>
> So do it in the one place. Don't make a function that does it and that
> others will start using because it's "simple".
Ok, fair enough. I'll make up a patch to remove that other
"unregister_wait" function in the driver core.
thanks,
greg k-h
next prev parent reply other threads:[~2004-01-23 18:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 16:58 PATCH: (as177) Add class_device_unregister_wait() and platform_device_unregister_wait() to the driver model core Alan Stern
2004-01-23 17:42 ` Linus Torvalds
2004-01-23 18:03 ` Alan Stern
2004-01-23 18:10 ` viro
2004-01-23 18:18 ` Greg KH
2004-01-23 18:15 ` Linus Torvalds
2004-01-23 18:31 ` Greg KH
2004-01-23 18:11 ` Greg KH
2004-01-23 18:19 ` Linus Torvalds
2004-01-23 18:27 ` Greg KH [this message]
2004-01-25 17:32 ` Alan Stern
2004-01-25 19:02 ` Linus Torvalds
2004-01-25 20:21 ` viro
2004-01-27 6:51 ` Rusty Russell
2004-01-27 13:56 ` Roman Zippel
2004-01-27 23:29 ` Rusty Russell
2004-01-28 2:36 ` Roman Zippel
2004-01-28 3:54 ` Rusty Russell
2004-01-25 23:12 ` Steve Youngs
2004-01-26 3:22 ` Adam Kropelin
2004-01-26 5:06 ` Steve Youngs
2004-01-26 5:21 ` Valdis.Kletnieks
2004-01-26 5:55 ` Steve Youngs
2004-01-26 6:25 ` Valdis.Kletnieks
2004-01-26 8:48 ` Helge Hafting
2004-01-26 15:50 ` Adam Kropelin
2004-01-26 16:22 ` Roman Zippel
2004-01-27 19:32 ` Russell King
2004-01-27 20:28 ` Greg KH
2004-01-27 20:29 ` Greg KH
2004-01-28 2:03 ` Roman Zippel
2004-01-28 2:17 ` viro
2004-01-28 2:53 ` Roman Zippel
2004-01-27 6:41 ` Rusty Russell
2004-01-23 19:45 ` viro
2004-01-26 5:50 ` Rusty Russell
2004-01-26 15:51 ` Alan Stern
2004-01-27 22:55 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040123182714.GF23169@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox