From: Greg KH <greg@kroah.com>
To: davej@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: Suspicious pointer usage in kobil_sct driver.
Date: Fri, 23 Jan 2004 12:41:35 -0800 [thread overview]
Message-ID: <20040123204135.GD23959@kroah.com> (raw)
In-Reply-To: <E1Ajuub-0000xh-00@hardwired>
On Fri, Jan 23, 2004 at 06:35:25AM +0000, davej@redhat.com wrote:
> Greg, is this what's intended here?
Yes, your patch is correct. I'll go apply it, thanks.
greg k-h
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
> --- bk-linus/drivers/usb/serial/kobil_sct.c 2003-09-29 20:00:01.000000000 +0100
> +++ linux-2.5/drivers/usb/serial/kobil_sct.c 2004-01-23 05:06:40.000000000 +0000
> @@ -651,7 +651,7 @@ static int kobil_ioctl(struct usb_seria
> return 0;
>
> case TCSETS: // 0x5402
> - if (! &port->tty->termios) {
> + if (!(port->tty->termios)) {
> dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
> return -ENOTTY;
> }
next prev parent reply other threads:[~2004-01-23 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 6:35 Suspicious pointer usage in kobil_sct driver davej
2004-01-23 20:41 ` Greg KH [this message]
2004-01-27 0:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040123204135.GD23959@kroah.com \
--to=greg@kroah.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox