public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: linux1394-devel@lists.sourceforge.net
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Message about PCILynx in kernel config
Date: Fri, 23 Jan 2004 21:05:20 +0100	[thread overview]
Message-ID: <20040123210520.08108f9f.khali@linux-fr.org> (raw)

Hi all,

This is a proposed patch to alter the conditions under which the PCILynx
message is displayed while configuring Linux 2.6. The way it is now, a
user with PCI and I2C both disabled will see a message stating that
"PCILynx requires I2C". If the user goes to the I2C section and selects
I2C, then comes back to the IEEE 1394 section, the message will have
disappeared (because I2C isn't missing anymore) but the PCILynx option
will not show (because PCI is still not selected).

I think it might be confusing, so I suggest that the message shouldn't
be displayed at all if PCI isn't selected. And here's a simple patch
that does just this. Built against and tested on Linux 2.6.2-rc1.

Thanks for your attention.

--- linux-2.6.2-rc1/drivers/ieee1394/Kconfig.orig	2004-01-22 10:37:43 +0100
+++ linux-2.6.2-rc1/drivers/ieee1394/Kconfig	2004-01-22 10:43:10 +0100
@@ -52,7 +52,7 @@
 	depends on IEEE1394
 
 comment "Texas Instruments PCILynx requires I2C"
-	depends on IEEE1394 && I2C=n
+	depends on PCI && IEEE1394 && I2C=n
 
 config IEEE1394_PCILYNX
 	tristate "Texas Instruments PCILynx support"


-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

             reply	other threads:[~2004-01-23 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-23 20:05 Jean Delvare [this message]
2004-01-23 19:24 ` Message about PCILynx in kernel config Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040123210520.08108f9f.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox